From: matz@... (Yukihiro Matsumoto) Date: 2002-09-11T00:23:09+09:00 Subject: Re: [Cleanup, fixes] string.c Hi, In message "Re: [Cleanup, fixes] string.c" on 02/09/09, Michal Rokos writes: | based on matz's recomendations I made new version. | (Massive deletes are because matz said "discard".) I meant discarding a flag, not your modification. Your changes seems OK. But I want functions to be static as much as possible, so rb_str_modify_check() and str_independent() are better to be static. In addition, I miss a few modifies you dropped. I will do it for you. matz.