From: "funny_falcon (Yura Sokolov)" Date: 2012-03-27T00:18:15+09:00 Subject: [ruby-core:43687] [ruby-trunk - Feature #5903] Optimize st_table (take 2) Issue #5903 has been updated by funny_falcon (Yura Sokolov). Add couple of commits to pull request https://github.com/ruby/ruby/pull/107 : 1. Removal of ST_CHECK . ST_CHECK were always returned instead of ST_CONTINUE inside of some st_foreach loops. Now such calls to st_foreach are converted to calls to st_foreach_check. So that, there is no reason to differentiate ST_CHECK and ST_CONTINUE, which simplifies calling code a bit. Also, it allows to simplify st_foreach_check code. 2. Traditionally, ultrapacking for empty and one element tables ---------------------------------------- Feature #5903: Optimize st_table (take 2) https://bugs.ruby-lang.org/issues/5903#change-25183 Author: funny_falcon (Yura Sokolov) Status: Open Priority: Normal Assignee: Category: core Target version: 2.0.0 Given some of preparations to this patches already merged into ruby-trunk, I suggest patches for improving st_table second time (first were #5789): 1) Usage of packing for st_table of any kind, not only for numeric hashes. Most of hashes, allocated during page render in Rails are smaller than 6 entries. In fact, during rendering "Issues" page of Redmine, 40% of hashes not even grows above 1 entry. They are small options hashes, passed to numerous helper methods. This patch packs hashes upto 6 entries in a way like numeric hashes from trunk. Also it pack hashes of size 0 and 1 into `st_table` inself, so that there is no need to allocate any "bins" at all. https://github.com/ruby/ruby/pull/84.patch https://github.com/ruby/ruby/pull/84 2) Usage of specialized pool for allocating st_table, st_table_entry structures and st_table.bins of smallest size (11) Usage of specialized pool for this allocations give great speedup for hash creation. Also it gives countable reduction of memory consumption. https://github.com/ruby/ruby/pull/83.patch https://github.com/ruby/ruby/pull/83 First patch gives little overhead for creating hashes bigger than 6 entries when applied alone. But both patches combined are not slower than ruby-trunk for hashes of any size. Performance testing is here https://gist.github.com/1626602 -- http://bugs.ruby-lang.org/