From: Eric Hodel <drbrain@...7.net>
Date: 2011-09-24T07:06:03+09:00
Subject: [ruby-core:39687] Re: [ruby-cvs:40472] drbrain:r33294 (trunk): * test/openssl/test_ssl.rb (class OpenSSL): Test


On Sep 21, 2011, at 8:49 PM, Martin Bo�let wrote:

> 2011/9/19 Eric Hodel <drbrain@segment7.net>:
>> On Sep 19, 2011, at 11:33 AM, NARUSE, Yui wrote:
>>> It seems duplicated test with tests in test/openssl/test_ssl_session.rb.
>> 
>> You are right.
>> 
>> How should the tests be organized?  I usually make the file names match the class names so SSLSocket#session tests would belong in test/openssl/test_ssl_socket.rb, but other SSLSocket tests live in test/openssl/test_ssl.rb so I did not think to check test_ssl_session.rb.
>> 
>> Martin, do you have an opinion?
> 
> If I understand correctly, you would suggest to merge the two files?
> 
> I generally like the idea of matching file and class names.

No, I want matching file and class names, so SSLSocket tests should be moved from test_ssl.rb to test_ssl_socket.rb

> I'm not sure, I would tend towards using matching files/classes for now
> until it feels appropriate to split.
> 
> What do you think, Hiroshi?
> 
> Does anyone else handle this totally different from what Eric suggested?

If nobody objects I can do this work.