From: Usaku NAKAMURA <redmine@...>
Date: 2011-09-14T23:50:46+09:00
Subject: [ruby-core:39554] [Ruby 1.9 - Bug #5325][Assigned]  Bug in win32.c CreateChild


Issue #5325 has been updated by Usaku NAKAMURA.

Category set to core
Status changed from Open to Assigned
Assignee set to Yuki Sonoda
Target version set to 1.9.2

this is backport bug.

Index: win32/win32.c
===================================================================
--- win32/win32.c	(revision 33270)
+++ win32/win32.c	(working copy)
@@ -1040,7 +1040,7 @@ CreateChild(const char *cmd, const char
 
     dwCreationFlags = (NORMAL_PRIORITY_CLASS);
 
-    if (lstrlenW(cmd) > 32767) {
+    if (strlen(cmd) > 32767) {
 	child->pid = 0;		/* release the slot */
 	errno = E2BIG;
 	return NULL;

----------------------------------------
Bug #5325:  Bug in win32.c CreateChild
http://redmine.ruby-lang.org/issues/5325

Author: James French
Status: Assigned
Priority: Normal
Assignee: Yuki Sonoda
Category: core
Target version: 1.9.2
ruby -v: -


 Hi,
 
 Revision 31811 by yugui (http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=31811) which was merged from the trunk contains a bug. It should be lstrlen instead of lstrlenW as its a char* not a wchar_t*. This has caused us a lot of problems with spawn failing spuriously.
 
 This should really be corrected on the 1.9.2 branch (it looks like the code has moved on on the trunk and its not an issue).
 
 Given that its a one character change and I'm not set up for submitting patches would someone be able to fix this for me?
 
 As a side note, compiling with warnings as errors would have caught this....
 
 When is the next 1.9.2 patch release due?
 
 Cheers,
 James


-- 
http://redmine.ruby-lang.org