From: James French Date: 2011-09-14T22:07:31+09:00 Subject: [ruby-core:39550] Bug in win32.c CreateChild --_000_950618E0D00138499BE7CC487EBF646D66FF123A26WOODCHUCKNMlo_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Revision 31811 by yugui (http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view= =3Drevision&revision=3D31811) which was merged from the trunk contains a bu= g. It should be lstrlen instead of lstrlenW as its a char* not a wchar_t*. = This has caused us a lot of problems with spawn failing spuriously. This should really be corrected on the 1.9.2 branch (it looks like the code= has moved on on the trunk and its not an issue). Given that its a one character change and I'm not set up for submitting pat= ches would someone be able to fix this for me? As a side note, compiling with warnings as errors would have caught this...= . When is the next 1.9.2 patch release due? Cheers, James --_000_950618E0D00138499BE7CC487EBF646D66FF123A26WOODCHUCKNMlo_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi,

Revision 31811 by yugui (http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=3Drevision&= amp;revision=3D31811) which was merged from the trunk contains a bug. It should be lstrlen instea= d of lstrlenW as its a char* not a wchar_t*. This has caused us a lot of problem= s with spawn failing spuriously.

This should really be corrected on the 1.9.2 branch (i= t looks like the code has moved on on the trunk and its not an issue).

Given that its a one character change and I’m no= t set up for submitting patches would someone be able to fix this for me?

As a side note, compiling with warnings as errors woul= d have caught this....

When is the next 1.9.2 patch release due?

Cheers,

James

--_000_950618E0D00138499BE7CC487EBF646D66FF123A26WOODCHUCKNMlo_--