From: Eric Wong <normalperson@...>
Date: 2011-08-17T11:31:59+09:00
Subject: [ruby-core:39000] [Ruby 1.9 - Bug #5199][Open] ext/tk: RB_GC_GUARD seems to be needed in several places


Issue #5199 has been reported by Eric Wong.

----------------------------------------
Bug #5199: ext/tk: RB_GC_GUARD seems to be needed in several places
http://redmine.ruby-lang.org/issues/5199

Author: Eric Wong
Status: Open
Priority: Normal
Assignee: 
Category: ext
Target version: 1.9.x
ruby -v: ruby 1.9.4dev (2011-08-11 trunk 32931) [x86_64-linux]


I noticed the following in ext/tk/tkutil/tkutil.c:

    rb_warning("fail to convert '%s' to string for Tk",
                   RSTRING_PTR(rb_funcall(obj, rb_intern("inspect"), 0,
                   0)));

    id = rb_intern(RSTRING_PTR(rb_str_cat2(rb_str_new2("@"), str)));

I don't use or know the Tk ext at all, but the above examples do not
appear safe from a GC perspective.  Compilers can optimize the original
VALUE away entirely so GC can collect.

RSTRING_PTR (being a macro,) may also evaluate its arguments multiple
times.



-- 
http://redmine.ruby-lang.org