From: Luis Lavena <luislavena@...>
Date: 2011-06-28T09:49:19+09:00
Subject: [ruby-core:37594] [Ruby 1.9 - Bug #4937] trunk@32244 MinGW build failure - thread_win32.c


Issue #4937 has been updated by Luis Lavena.

Category set to build
Assignee set to Koichi Sasada

This was introduced in r32244 by Koichi Sasada. Assigning it to him.

Sasada-san, seems the signature change in thread_win32.c is missing, the following patch solves the compilation but I'm unsure the extend of the needed changes:


diff --git a/thread_win32.c b/thread_win32.c
index 5c20650..68fb346 100644
--- a/thread_win32.c
+++ b/thread_win32.c
@@ -745,7 +745,7 @@ rb_thread_create_timer_thread(void)
 }

 static int
-native_stop_timer_thread(void)
+native_stop_timer_thread(int close_anyway)
 {
     int stopped = --system_working <= 0;
     if (stopped) {


----------------------------------------
Bug #4937: trunk@32244 MinGW build failure - thread_win32.c  
http://redmine.ruby-lang.org/issues/4937

Author: Jon Forums
Status: Open
Priority: Normal
Assignee: Koichi Sasada
Category: build
Target version: 
ruby -v: ruby 1.9.3dev (2011-06-27 trunk 32242) [i386-mingw32]


The signature of `native_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread_win32.c#L748

conflicts with it's usage by `rb_thread_stop_timer_thread` at

    https://github.com/ruby/ruby/blob/trunk/thread.c#L2989

resulting in the following build error when using the RubyInstaller build recipes and gcc.exe (tdm-1) 4.5.2:

<pre>
compiling ../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c: In function 'rb_thread_stop_timer_thread':
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread.c:2989:5: error: too many arguments to function 'native_stop_timer_thread'
../../../../Users/Jon/Documents/RubyDev/ruby-git/thread_win32.c:748:1: note: declared here
</pre> 


-- 
http://redmine.ruby-lang.org