From: Eric Wong <normalperson@...>
Date: 2011-05-04T11:02:46+09:00
Subject: [ruby-core:35990] Re: [Ruby 1.9 - Feature #4531] [PATCH 0/7] use	poll() instead of select() in certain cases

Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> I've commited following five patches.
> 
> 0001-rb_wait_for_single_fd-initial-implementation.patch
> 0002-io-wait-switch-to-rb_wait_for_single_fd.patch
> 0003-ext-socket-init.c-simplify-wait_connectable-using-rb.patch
> 0004-readline-use-rb_wait_for_single_fd-instead-of-rb_thr.patch
> 0006-rb_wait_for_single_fd-use-poll-on-Linux.patch

Thanks, I'm preparing some comments + tests in response to your
comments on 0006.

> But I haven't commited below one patch.
> 
> 0005-io.c-IO.select-use-rb_wait_for_single_fd-for-single-.patch
> 
> I'm waiting performance fix or explanation why should we commit it.

I'm OK with rejecting 0005. It's too ugly in retrospect...

Instead the io/wait extension should be expanded to be able to check for
writability, too.  Maybe by adding a new method:

	IO#wait_writable(timeout = 0)

-- 
Eric Wong