From: James Gray <james@...>
Date: 2011-04-27T03:42:49+09:00
Subject: [ruby-core:35908] Re: [Ruby 1.9 - Bug #4603][Open] lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT

--20cf307f3a72b9651404a1d6b006
Content-Type: text/plain; charset=UTF-8

On Tue, Apr 26, 2011 at 11:27 AM, Nobuyoshi Nakada <nobu@ruby-lang.org>wrote:

> Hi,
>
> At Mon, 25 Apr 2011 22:57:52 +0900,
> James Gray wrote in [ruby-core:35878]:
> > The issue is that a mode of "rb" is being used to suppress newline
> > translation on Windows.  However, that's also switching my Encoding to
> > ASCII-8BIT.  Usually I love that feature, but here it's not what I want.
>  Is
> > there anyway to shut off the translation and not get the encoding change?
>
> Now fixed so that universal_newline: false can work.  What's
> about the following patch?
>

This looks right to me.  Please commit.

James Edward Gray II

--20cf307f3a72b9651404a1d6b006
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Tue, Apr 26, 2011 at 11:27 AM, Nobuyoshi Naka=
da <span dir=3D"ltr">&lt;<a href=3D"mailto:nobu@ruby-lang.org">nobu@ruby-la=
ng.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi,<br>
<br>
At Mon, 25 Apr 2011 22:57:52 +0900,<br>
James Gray wrote in [ruby-core:35878]:<br>
<div class=3D"im">&gt; The issue is that a mode of &quot;rb&quot; is being =
used to suppress newline<br>
&gt; translation on Windows. =C2=A0However, that&#39;s also switching my En=
coding to<br>
&gt; ASCII-8BIT. =C2=A0Usually I love that feature, but here it&#39;s not w=
hat I want. =C2=A0Is<br>
&gt; there anyway to shut off the translation and not get the encoding chan=
ge?<br>
<br>
</div>Now fixed so that universal_newline: false can work. =C2=A0What&#39;s=
<br>
about the following patch?<br></blockquote><div><br></div><div>This looks r=
ight to me. =C2=A0Please commit.</div><div><br></div><div>James Edward Gray=
 II=C2=A0</div></div>

--20cf307f3a72b9651404a1d6b006--