From: Marc-Andre Lafortune Date: 2011-04-10T11:56:09+09:00 Subject: [ruby-core:35680] Re: [Ruby 1.9 - Feature #4539][Assigned] Array#zip_with Hi, On Sat, Apr 9, 2011 at 4:29 AM, Kenta Murata wrote: > I implemented the features in C, and wrote tests for them. > Please see the following diffs: > https://github.com/mrkn/ruby/commit/9c7ead0e385b6a17dafa5bc8b4389e1baf2e3040 Looks good, but is there a reason to use `rb_funcall` for the reduce? Typically MRI calls directly the C implementation wherever possible, and I would suggest doing that here too. On Sat, Apr 9, 2011 at 9:13 AM, Yukihiro Matsumoto wrote: > I am not sure whether adding new zip_with or adding zip with symbol at > last would be better. �Any opinion? I also vote for `zip` with an optional symbol as last argument (as in the patch). I don't see a downside and it seems logical. -- Marc-Andr�