[#35446] [Ruby 1.9 - Bug #4477][Open] Kernel:exec and backtick (`) don't work for certain system commands — Joachim Wuttke <j.wuttke@...>

10 messages 2011/03/07

[#35476] [Ruby 1.9 - Bug #4489][Open] [PATCH] Encodings with /-(unix|dos|mac)\Z/ — "James M. Lawrence" <quixoticsycophant@...>

20 messages 2011/03/10

[#35552] [Ruby 1.9 - Feature #4523][Open] Kernel#require to return the path of the loaded file — Alex Young <alex@...>

14 messages 2011/03/24

[#35565] [Ruby 1.9 - Feature #4531][Open] [PATCH 0/7] use poll() instead of select() in certain cases — Eric Wong <normalperson@...>

33 messages 2011/03/28

[#35566] [Ruby 1.9 - Feature #4532][Open] [PATCH] add IO#pread and IO#pwrite methods — Eric Wong <normalperson@...>

12 messages 2011/03/28

[#35586] [Ruby 1.9 - Feature #4538][Open] [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O — Eric Wong <normalperson@...>

9 messages 2011/03/29

[ruby-core:35453] [Ruby 1.8 - Bug #4467][Closed] Process.maxgroups= should only accept numeric values

From: Motohiro KOSAKI <kosaki.motohiro@...>
Date: 2011-03-07 11:22:38 UTC
List: ruby-core #35453
Issue #4467 has been updated by Motohiro KOSAKI.

Status changed from Open to Closed


----------------------------------------
Bug #4467: Process.maxgroups= should only accept numeric values
http://redmine.ruby-lang.org/issues/4467

Author: Daniel Berger
Status: Closed
Priority: Normal
Assignee: 
Category: core
Target version: Ruby 1.8.7
ruby -v: -


At the moment Process.maxgroups= accepts non-numeric values, which results in defaulting to 4096. IMO it should raise a TypeError.

diff --git a/process.orig b/process.c
index f658fa9..c3c4a1f 100644
--- a/process.orig
+++ b/process.c
@@ -2752,7 +2752,7 @@ proc_getmaxgroups(obj)
 static VALUE
 proc_setmaxgroups(VALUE obj, VALUE val)
 {
-    size_t  ngroups = FIX2INT(val);
+    size_t  ngroups = NUM2INT(val);
 
     if (ngroups > 4096)
        ngroups = 4096;


-- 
http://redmine.ruby-lang.org

In This Thread