From: "James M. Lawrence" <redmine@...>
Date: 2011-01-31T05:32:48+09:00
Subject: [ruby-core:34998] [Ruby 1.9-Bug#4347][Open] Tracing cannot be re-enabled after callcc [patch]


--mimepart_4d45caebb7767_5983a1795da2371
Content-Type: text/plain
Content-Transfer-Encoding: Quoted-printable
Content-Disposition: inline

Bug #4347: Tracing cannot be re-enabled after callcc [patch]
http://redmine.ruby-lang.org/issues/show/4347

Author: James M. Lawrence
Status: Open, Priority: Normal
Category: core, Target version: 1.9.x
ruby -v: ruby 1.9.3dev (2011-01-30 trunk 30735) [i386-darwin9.8.0]

% patch -p1 < test_continuation_tracing.patch =

patching file test/ruby/test_continuation.rb
% ./ruby -v test/ruby/test_continuation.rb =

ruby 1.9.3dev (2011-01-30 trunk 30735) [i386-darwin9.8.0]
Run options: =


# Running tests:

......FF

Finished tests in 0.080788s, 99.0246 tests/s, 148.5369 assertions/s.

  1) Failure:
test_tracing_with_set_trace_func(TestContinuation) [test/ruby/test_contin=
uation.rb:99]:
<3> expected but was
<1>.

  2) Failure:
test_tracing_with_thread_set_trace_func(TestContinuation) [test/ruby/test=
_continuation.rb:121]:
<3> expected but was
<0>.

In thread.c (thread_suppress_tracing) the code after (*func)(arg, running=
)
is not executed, causing th->tracing to not be cleared.

This two-line patch works, though it may only address a symptom.


----------------------------------------
http://redmine.ruby-lang.org

--mimepart_4d45caebb7767_5983a1795da2371
Content-Type: text/plain; name=test_continuation_tracing.patch
Content-Transfer-Encoding: Base64
Content-Disposition: attachment; filename=test_continuation_tracing.patch

ZGlmZiAtLWdpdCBhL3Rlc3QvcnVieS90ZXN0X2NvbnRpbnVhdGlvbi5yYiBi
L3Rlc3QvcnVieS90ZXN0X2NvbnRpbnVhdGlvbi5yYgppbmRleCBjNzE5ZGI4
Li42NDM5MGQ4IDEwMDY0NAotLS0gYS90ZXN0L3J1YnkvdGVzdF9jb250aW51
YXRpb24ucmIKKysrIGIvdGVzdC9ydWJ5L3Rlc3RfY29udGludWF0aW9uLnJi
CkBAIC03Nyw1ICs3Nyw0OCBAQCBjbGFzcyBUZXN0Q29udGludWF0aW9uIDwg
VGVzdDo6VW5pdDo6VGVzdENhc2UKICAgICB9LCAnW3J1YnktZGV2OjM0ODAy
XScKICAgZW5kCiAKKyAgZGVmIHRyYWNpbmdfd2l0aF9zZXRfdHJhY2VfZnVu
YworICAgIGNvbnQgPSBuaWwKKyAgICBmdW5jID0gbGFtYmRhIGRvIHwqYXJn
c3wKKyAgICAgIEBtZW1vICs9IDEKKyAgICAgIGNvbnQuY2FsbChuaWwpCisg
ICAgZW5kCisgICAgY29udCA9IGNhbGxjYyB7IHxjY3wgY2MgfQorICAgIGlm
IGNvbnQKKyAgICAgIHNldF90cmFjZV9mdW5jKGZ1bmMpCisgICAgZWxzZQor
ICAgICAgc2V0X3RyYWNlX2Z1bmMobmlsKQorICAgIGVuZAorICBlbmQKKwor
ICBkZWYgdGVzdF90cmFjaW5nX3dpdGhfc2V0X3RyYWNlX2Z1bmMKKyAgICBA
bWVtbyA9IDAKKyAgICB0cmFjaW5nX3dpdGhfc2V0X3RyYWNlX2Z1bmMKKyAg
ICB0cmFjaW5nX3dpdGhfc2V0X3RyYWNlX2Z1bmMKKyAgICB0cmFjaW5nX3dp
dGhfc2V0X3RyYWNlX2Z1bmMKKyAgICBhc3NlcnRfZXF1YWwgMywgQG1lbW8K
KyAgZW5kCisKKyAgZGVmIHRyYWNpbmdfd2l0aF90aHJlYWRfc2V0X3RyYWNl
X2Z1bmMKKyAgICBjb250ID0gbmlsCisgICAgZnVuYyA9IGxhbWJkYSBkbyB8
KmFyZ3N8CisgICAgICBAbWVtbyArPSAxCisgICAgICBjb250LmNhbGwobmls
KQorICAgIGVuZAorICAgIGNvbnQgPSBjYWxsY2MgeyB8Y2N8IGNjIH0KKyAg
ICBpZiBjb250CisgICAgICBUaHJlYWQuY3VycmVudC5zZXRfdHJhY2VfZnVu
YyhmdW5jKQorICAgIGVsc2UKKyAgICAgIFRocmVhZC5jdXJyZW50LnNldF90
cmFjZV9mdW5jKG5pbCkKKyAgICBlbmQKKyAgZW5kCisKKyAgZGVmIHRlc3Rf
dHJhY2luZ193aXRoX3RocmVhZF9zZXRfdHJhY2VfZnVuYworICAgIEBtZW1v
ID0gMAorICAgIHRyYWNpbmdfd2l0aF90aHJlYWRfc2V0X3RyYWNlX2Z1bmMK
KyAgICB0cmFjaW5nX3dpdGhfdGhyZWFkX3NldF90cmFjZV9mdW5jCisgICAg
dHJhY2luZ193aXRoX3RocmVhZF9zZXRfdHJhY2VfZnVuYworICAgIGFzc2Vy
dF9lcXVhbCAzLCBAbWVtbworICBlbmQKIGVuZAogCg==

--mimepart_4d45caebb7767_5983a1795da2371
Content-Type: text/plain; name=continuation_tracing.patch
Content-Transfer-Encoding: Base64
Content-Disposition: attachment; filename=continuation_tracing.patch

ZGlmZiAtLWdpdCBhL3RocmVhZC5jIGIvdGhyZWFkLmMKaW5kZXggNjlmYzI5
OS4uNzMxMjE4NCAxMDA2NDQKLS0tIGEvdGhyZWFkLmMKKysrIGIvdGhyZWFk
LmMKQEAgLTQwODQsNiArNDA4NCw3IEBAIHNldF90cmFjZV9mdW5jKFZBTFVF
IG9iaiwgVkFMVUUgdHJhY2UpCiAgICAgcmJfcmVtb3ZlX2V2ZW50X2hvb2so
Y2FsbF90cmFjZV9mdW5jKTsKIAogICAgIGlmIChOSUxfUCh0cmFjZSkpIHsK
KwlHRVRfVEhSRUFEKCktPnRyYWNpbmcgPSBFVkVOVF9SVU5OSU5HX05PVEhJ
Tkc7CiAJcmV0dXJuIFFuaWw7CiAgICAgfQogCkBAIC00MTQwLDYgKzQxNDEs
NyBAQCB0aHJlYWRfc2V0X3RyYWNlX2Z1bmNfbShWQUxVRSBvYmosIFZBTFVF
IHRyYWNlKQogICAgIHJiX3RocmVhZHB0cl9yZW1vdmVfZXZlbnRfaG9vayh0
aCwgY2FsbF90cmFjZV9mdW5jKTsKIAogICAgIGlmIChOSUxfUCh0cmFjZSkp
IHsKKwl0aC0+dHJhY2luZyA9IEVWRU5UX1JVTk5JTkdfTk9USElORzsKIAly
ZXR1cm4gUW5pbDsKICAgICB9CiAgICAgdGhyZWFkX2FkZF90cmFjZV9mdW5j
KHRoLCB0cmFjZSk7Cg==

--mimepart_4d45caebb7767_5983a1795da2371--