From: Martin Bosslet <redmine@...>
Date: 2011-01-30T03:19:45+09:00
Subject: [ruby-core:34987] [Ruby 1.9-Bug#4344][Open] [ext/openssl] BN comparison to nil fails


--mimepart_4d445a1d3b5e9_59835aef376189f
Content-Type: text/plain
Content-Transfer-Encoding: Quoted-printable
Content-Disposition: inline

Bug #4344: [ext/openssl] BN comparison to nil fails
http://redmine.ruby-lang.org/issues/show/4344

Author: Martin Bosslet
Status: Open, Priority: Normal
Category: ext, Target version: 1.9.2
ruby -v: all 1.9.2

Hi all,

this currently fails in all 1.9.2 versions including trunk:

require 'openssl'

bn =3D OpenSSL::BN.new("1")
bn =3D=3D nil

=3D> in `eql?': Cannot convert into OpenSSL::BN (TypeError)

The reason is that GetBNPtr(VALUE obj) did not cover the case for obj bei=
ng nil.
Patch is attached.

Regards,
Martin


----------------------------------------
http://redmine.ruby-lang.org

--mimepart_4d445a1d3b5e9_59835aef376189f
Content-Type: text/x-patch; name=fix_bn_cmp.diff
Content-Transfer-Encoding: Base64
Content-Disposition: attachment; filename=fix_bn_cmp.diff

SW5kZXg6IHJ1YnkvZXh0L29wZW5zc2wvb3NzbF9ibi5jCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIHJ1YnkvZXh0L29wZW5zc2wvb3NzbF9ibi5jCShy
ZXZpc2lvbiAzMDY4NCkKKysrIHJ1YnkvZXh0L29wZW5zc2wvb3NzbF9ibi5j
CSh3b3JraW5nIGNvcHkpCkBAIC02MywxMyArNjMsMTUgQEAKIAlHZXRCTihv
YmosIGJuKTsKICAgICB9IGVsc2Ugc3dpdGNoIChUWVBFKG9iaikpIHsKICAg
ICBjYXNlIFRfRklYTlVNOgogICAgIGNhc2UgVF9CSUdOVU06CiAJb2JqID0g
cmJfU3RyaW5nKG9iaik7CiAJaWYgKCFCTl9kZWMyYm4oJmJuLCBTdHJpbmdW
YWx1ZVB0cihvYmopKSkgewogCSAgICBvc3NsX3JhaXNlKGVCTkVycm9yLCBO
VUxMKTsKIAl9CiAJV3JhcEJOKGNCTiwgb2JqLCBibik7IC8qIEhhbmRsZSBw
b3RlbmNpYWwgbWVtIGxlYWtzICovCiAJYnJlYWs7CisgICAgY2FzZSBUX05J
TDoKKwlicmVhazsKICAgICBkZWZhdWx0OgogCW9zc2xfcmFpc2UocmJfZVR5
cGVFcnJvciwgIkNhbm5vdCBjb252ZXJ0IGludG8gT3BlblNTTDo6Qk4iKTsK
ICAgICB9CkluZGV4OiBydWJ5L3Rlc3Qvb3BlbnNzbC90ZXN0X2JuLnJiCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIHJ1YnkvdGVzdC9vcGVuc3NsL3Rl
c3RfYm4ucmIJKHJldmlzaW9uIDMwNjg0KQorKysgcnVieS90ZXN0L29wZW5z
c2wvdGVzdF9ibi5yYgkod29ya2luZyBjb3B5KQpAQCAtMTIsNiArMTIsMTIg
QEAKICAgICBPcGVuU1NMOjpCTi5uZXcoKDIgKiogMTA3IC0gMSkudG9fcygx
NiksIDE2KS5wcmltZT8KICAgICBPcGVuU1NMOjpCTi5uZXcoKDIgKiogMTI3
IC0gMSkudG9fcygxNiksIDE2KS5wcmltZT8oMSkKICAgZW5kCisKKyAgZGVm
IHRlc3RfY21wX25pbAorICAgIGJuID0gT3BlblNTTDo6Qk4ubmV3KCcxJykK
KyAgICBibiA9PSBuaWwKKyAgICBibiAhPSBuaWwKKyAgZW5kCiBlbmQKIAog
ZW5kCg==

--mimepart_4d445a1d3b5e9_59835aef376189f--