From: Yukihiro Matsumoto <matz@...>
Date: 2010-12-16T23:06:08+09:00
Subject: [ruby-core:33752] Re: [Ruby 1.9-Feature#4038] IO#advise

Hi,

In message "Re: [ruby-core:33751] Re: [Ruby 1.9-Feature#4038] IO#advise"
    on Thu, 16 Dec 2010 22:56:45 +0900, Run Paint Run Run <runrun@runpaint.org> writes:

|> Please check-in, but I think symbol initialization (:normal etc.) is
|> needed only when posix_fadvise(2) is available.
|
|The advantage of the current approach is that we can fail earlier.
|Otherwise, a script containing `io.advise([1,2,3])` would not raise an
|exception under Windows, but would if run under Linux.

No, no.  I meant lines like

    sym_normal = ID2SYM(rb_intern("normal"));
    sym_sequential = ID2SYM(rb_intern("sequential"));

can be wrapped by #ifdef HAVE_POSIX_FADVISE

							matz.