From: Yui NARUSE <redmine@...>
Date: 2010-11-28T04:22:42+09:00
Subject: [ruby-core:33434] [Ruby 1.9-Feature#4093] net/http rdoc improvements

Issue #4093 has been updated by Yui NARUSE.


I merge your patch, thanks!

Following are comments:

> +  #    url.query = params.inject([]) { |memo, (k, v)| memo << "#{k}=#{CGI::escape(v.to_s)}"; memo }.join("&")

You can use URI.encode_www_form(params).

> -  #     res = Net::HTTP.new(url.hostname, url.port).start {|http| http.request(req) }
> +  #     res = Net::HTTP.new(url.host, url.port).start {|http| http.request(req) }

url.hostname is correct.
see http://redmine.ruby-lang.org/issues/show/3788


> -  #     Net::HTTP::Proxy(proxy_addr, proxy_port).start('www.example.com') {|http|
> +  #     Net::HTTP.Proxy(proxy_addr, proxy_port).start('www.example.com') {|http|

Ruby sometimes use a method whose name begin with upper case,
like Integer(), Array(), and URI(). They are syntactically only a method,
but s semantically considered as a class method. Such method should be like
Net::HTTP::Proxy().
----------------------------------------
http://redmine.ruby-lang.org/issues/show/4093

----------------------------------------
http://redmine.ruby-lang.org