From: Evan Phoenix Date: 2010-07-07T01:18:18+09:00 Subject: [ruby-core:31089] Re: [Bug #3140] gem activation has changed between 1.8 and 1.9 On Jul 6, 2010, at 9:10 AM, James Tucker wrote: > > On 6 Jul 2010, at 16:49, Yusuke Endoh wrote: > >> Issue #3140 has been updated by Yusuke Endoh. >> >> >> Hi, >> >> I set a deadline of this discussion: 7/10 (Sat) 23:59 JST. >> 1.9.2 will be released in status quo unless we can agree on concrete >> solution and write a patch. >> >> IMO, it is no use just to complain. It is too late to broaden the >> discussion. Let's focus on the issue at hand, and please write a >> patch yourself. > > I have. http://github.com/rubygems/rubygems/compare/master...perflude > >> Or, complain directly to the maintainer for rubygems. > > I am. > > Is the above patch to rubygems actually acceptable for inclusion (via rubygems/fast.rb) to be included into ruby as a replacement for gem_prelude? No, the patch isn't acceptable as going into 1.9.2, because it has not gone through the normal rigor of rubygems testing. I see a few issues with it straight away. - Evan > >> -- >> Yusuke Endoh >> ---------------------------------------- >> http://redmine.ruby-lang.org/issues/show/3140 >> >> ---------------------------------------- >> http://redmine.ruby-lang.org >> > > >