[ruby-core:29428] Re: [Bug #3112] require "yaml" doesn't use psych as default

On Sun, Apr 11, 2010 at 09:20:15AM +0900, NARUSE, Yui wrote:
> (2010/04/11 8:48), Aaron Patterson wrote:
> > I am surprised about the rubygems failures.  With the following patch, I
> > am able to run the rubygems tests, like this:
> > 
> > $ GEM_HOME=/tmp GEM_PATH=/tmp make test-all TESTS=rubygems
> > 
> > diff --git a/lib/yaml.rb b/lib/yaml.rb
> > index 9b5a9b2..0151973 100644
> > --- a/lib/yaml.rb
> > +++ b/lib/yaml.rb
> > @@ -40,4 +40,4 @@ module Psych
> >     ENGINE = YAML::ENGINE
> >   end
> > 
> > -YAML::ENGINE.yamler = engine
> > +YAML::ENGINE.yamler = 'psych'
> > diff --git a/test/rubygems/gemutilities.rb b/test/rubygems/gemutilities.rb
> > index bb94750..cea1dbe 100644
> > --- a/test/rubygems/gemutilities.rb
> > +++ b/test/rubygems/gemutilities.rb
> > @@ -8,13 +8,7 @@ else
> >     require 'rubygems'
> >   end
> >   require 'fileutils'
> > -begin
> > -  gem 'minitest', '>= 1.3.1'
> > -  require 'minitest/unit'
> > -rescue Gem::LoadError
> > -  warn "Install minitest gem>= 1.3.1"
> > -  raise
> > -end
> > +require 'minitest/unit'
> >   require 'tmpdir'
> >   require 'uri'
> >   require 'rubygems/package'
> 
> Bundled minitest is 1.6.0(-dev?) after r27076, so why this is needed...

I'm not sure.  I've applied this to trunk with Eric's permission.

> > diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb
> > index 5979890..337073f 100644
> > --- a/test/rubygems/test_gem_specification.rb
> > +++ b/test/rubygems/test_gem_specification.rb
> > @@ -1,5 +1,6 @@
> >   require_relative 'gemutilities'
> >   require 'stringio'
> > +require 'date'
> >   require 'rubygems/specification'
> > 
> >   class TestGemSpecification<  RubyGemTestCase
> > 
> > 
> > Some of the Syck YAML tests (like test_spec_application_family and
> > test_spec_url_escaping) contain invalid YAML, so Psych will raise an
> > exception.  Do `diff test/yaml/test_yaml.rb test/psych/test_yaml.rb` to
> > see the differences.
> 
> Yeah, I know some of them are intended.
> I want to confirm taht all of them are from invalid YAML.
> 
> > I will make test/yaml/* use the syck engine.
> 
> OK, it may have to move to test/syck.

Yes.  I've moved test/yaml to test/syck.

> > I can't run make test-all on Snow Leopard because of the problem I
> > mentioned in [ruby-core:29087].  I will try on linux.
> 
> Can you make a ticket in Redmine for [ruby-core:29087]?

Done:  http://redmine.ruby-lang.org/issues/show/3124

> For workaround you can run test-all like following:
> make RUBYOPT=-w TESTS='-v -x "test/drb|test/socket"' test-all

I will use this.  Thank you!

-- 
Aaron Patterson
http://tenderlovemaking.com/