From: Stephen Sykes <redmine@...>
Date: 2010-03-02T18:54:34+09:00
Subject: [ruby-core:28410] [Feature #2515] Array#select!

Issue #2515 has been updated by Stephen Sykes.


I agree with Marc-Andre, and also with his suggestion of keep_if.

I have sometimes wished for each of these methods, and it seems logical and reasonable that they should exist.

As for the names, I have reviewed the previous discussions, and I strongly suggest, as a native english speaker, that no-one will have any trouble understanding how select! or keep_if work.  They are good and understandable names.

The use case for select! is clear.  I quote from an example from the original discussion:

Code starts out as something like

result = collection.map { |x| ... }.select { |x| ... }

But then I might add code to the "map" part, and the code now extends
over a few lines and looks poor if it's chained together. So it gets
changed to:

result = collection.map { |x|
...
}
result.select! { |x| ... }


+1 from me, a useful addition.


----------------------------------------
http://redmine.ruby-lang.org/issues/show/2515

----------------------------------------
http://redmine.ruby-lang.org