From: Monty Williams <monty.williams@...>
Date: 2009-12-05T10:48:30+09:00
Subject: [ruby-core:27053] Re: [Bug #2428] URI::Generic#eql? broken when passed nil

We should contribute an mspec for this if one doesn't already exist.

----- Original Message -----
From: "Peter McLain" <redmine@ruby-lang.org>
To: ruby-core@ruby-lang.org
Sent: Thursday, December 3, 2009 5:14:33 PM GMT -08:00 US/Canada Pacific
Subject: [ruby-core:27019] [Bug #2428] URI::Generic#eql? broken when passed nil

Bug #2428: URI::Generic#eql? broken when passed nil
http://redmine.ruby-lang.org/issues/show/2428

Author: Peter McLain
Status: Open, Priority: Normal
Category: lib, Target version: Ruby 1.8.6
ruby -v: ruby 1.8.6 (2009-08-04 patchlevel 383) [i686-darwin9.8.0]

URI::Generic#eql? does not check for nil:

    def eql?(oth)
      self.component_ary.eql?(oth.component_ary)
    end

Test Case:

require 'uri'
uri = URI.parse 'http://gemcutter.org'

uri.eql?(nil)  # => blows up

Fix:

    def eql?(oth)
      return true if self.equal?(oth)
      self.class.equal?(oth.class) &&
        self.component_ary.eql?(oth.component_ary)
    end


----------------------------------------
http://redmine.ruby-lang.org