From: Stephen Bannasch Date: 2009-02-15T04:57:41+09:00 Subject: [ruby-core:22102] Re: MBARI patches on GitHub At 6:18 PM +0900 2/14/09, Brent Roman wrote: >Michael, > >I have just posted the MBARI patches on GitHub at: > >http://github.com/brentr/matzruby/tree/v1_8_7_72-mbari > >I believe you can pull from it via this git URL: > >git://github.com/brentr/matzruby.git >Please do try to build from my git repo and let me know how that goes. Brent, thanks for putting them on github. This makes it very easy to follow your work now. Building it worked fine. When I built the latest v1_8_7_72-mbari branch: commit 6b169f9546ad52cb0edb9a19d48110e08f86a296 Author: Brent Roman Date: Fri Feb 13 23:06:56 2009 -0800 and ran the latest full suite of rubyspecs on it I got 8 failures and 14 errors. See the full output from mspec here: http://gist.github.com/64442 It doesn't look like your patches have much to do with those errors ... but I'm not sure. I haven't worked with 1.8.7 much. The trunk version of 1.8.7 doesn't build and install correctly on my system. Here's how I built and tested your branch: I already have the matzruby git repo cloned so I added the mbari repo as another remote, fetched and checked out the remote branch v1_8_7_72-mbari into my working dir. $ cd ruby/src/matzruby.git/ $ git remote add mbari git://github.com/brentr/matzruby.git $ git remote -v mbari git://github.com/brentr/matzruby.git origin git://github.com/rubyspec/matzruby.git $ git pull $ git fetch mbari $ git co -b v1_8_7_72-mbari mbari/v1_8_7_72-mbari Built it and made sure it can print it's version: $ autoconf && ./configure --prefix=/Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari $ make clean && make && make install $ /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/bin/ruby -v ruby 1.8.7 (2009-2-13 MBARI 7/0x8770 on patchlevel 72) [i686-darwin9.6.0] Here's a summary of the files that have changed between Brent's mbari branch and the tag v1_8_7_72: $ git diff --stat v1_8_7_72 ChangeLog | 197 +++++ common.mk | 2 +- eval.c | 2354 ++++++++++++++++++++++++++++++++---------------------- gc.c | 589 ++++++++------- intern.h | 2 +- missing/alloca.c | 8 +- node.h | 6 +- rubysig.h | 212 +++++- signal.c | 3 +- version.h | 17 +- 10 files changed, 2123 insertions(+), 1267 deletions(-) A closer look at the changes in my favorite diff viewer (GitX): $ git diff v1_8_7_72 | gitx Run the latest rubyspecs against it $ cd /Users/stephen/dev/ruby/src/rubyspec.git $ which mspec /Users/stephen/dev/ruby/src/mspec.git/bin/mspec $ git pull Already up-to-date. Running just the core rubyspec tests: $ mspec -t /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/bin/ruby core ruby 1.8.7 (2009-2-13 MBARI 7/0x8770 on patchlevel 72) [i686-darwin9.6.0] ..EE..EE.....................................................................E........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F....................................................................................................................................................................................................................................................... ......................................................................................................................................... 1) ARGF.bytes returns an Enumerable::Enumerator when passed no block ERROR NoMethodError: undefined method `be_an_instance_of' for # ./core/argf/shared/each_byte.rb:41 ./core/argf/shared/each_byte.rb:39 ./core/argf/bytes_spec.rb:2:in `all?' ./core/argf/bytes_spec.rb:5 ./core/argf/bytes_spec.rb:4 2) ARGF.chars returns an Enumerable::Enumerator when passed no block ERROR NoMethodError: undefined method `be_an_instance_of' for # ./core/argf/shared/each_char.rb:32 ./core/argf/shared/each_char.rb:30 ./core/argf/chars_spec.rb:2:in `all?' ./core/argf/chars_spec.rb:5 ./core/argf/chars_spec.rb:4 3) ARGF.each_byte returns an Enumerable::Enumerator when passed no block ERROR NoMethodError: undefined method `be_an_instance_of' for # ./core/argf/shared/each_byte.rb:41 ./core/argf/shared/each_byte.rb:39 ./core/argf/each_byte_spec.rb:2:in `all?' ./core/argf/each_byte_spec.rb:4 4) ARGF.each_char returns an Enumerable::Enumerator when passed no block ERROR NoMethodError: undefined method `be_an_instance_of' for # ./core/argf/shared/each_char.rb:32 ./core/argf/shared/each_char.rb:30 ./core/argf/each_char_spec.rb:2:in `all?' ./core/argf/each_char_spec.rb:5 ./core/argf/each_char_spec.rb:4 5) An exception occurred during: before :all ERROR LoadError: dlopen(/Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle, 9): Symbol not found: _rb_DLStdcallCallbackProcs Referenced from: /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle Expected in: flat namespace - /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle ./core/array/pack_spec.rb:2363 ./core/array/pack_spec.rb:2272:in `all?' ./core/array/pack_spec.rb:2426 6) An exception occurred during: before :all ERROR LoadError: dlopen(/Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle, 9): Symbol not found: _rb_DLStdcallCallbackProcs Referenced from: /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle Expected in: flat namespace - /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle /Users/stephen/dev/ruby/builds/mri/v1_8_7_72-mbari/lib/ruby/1.8/i686-darwin9.6.0/dl.bundle ./core/array/pack_spec.rb:2363 ./core/array/pack_spec.rb:2363:in `all?' ./core/array/pack_spec.rb:2475 7) Module#autoload shares the autoload request across dup'ed copies of modules FAILED Expected NameError but got TypeError (wrong autoload table: #) ./core/module/autoload_spec.rb:252 ./core/module/autoload_spec.rb:238:in `all?' ./core/module/autoload_spec.rb:15 Finished in 13.107626 seconds 1127 files, 5697 examples, 19595 expectations, 1 failure, 6 errors