From: Brent Roman <brent@...>
Date: 2009-01-21T18:21:19+09:00
Subject: [ruby-core:21483] Re: [Bug #744] memory leak in callcc?


Hi Nobu,

Yes, I plan to rebase my patches against the HEAD after I move them to git.
This should also make it easier for me to separate features from fixes.
I'll be traveling next week, so expect something in 2-3 weeks.

Regarding the patches already applied to HEAD:

MBARI1:
  Can you explain why the Continuation#thread method is not acceptable?
  It does seem to be an intrinsic property of every Continuation and
  without this method, one must often maintain a separate (weak) reference
  to the thread on which each continuation operates.

MBARI2:
  I like push/pop_thread_anchor() better than my hack to hide other threads'
stacks.
  However, I don't see code in rb_thread_save_context() to copy *only* the
active
  stack for each thread.  This is a very important optimization. 
  Are you doing this optimization some other way that I am overlooking?
  (To see how important it can be, try running my bogus1.rb and bogus2.rb
benchmarks)

MBARI4:
  I'll be happy to incorporate your clever eval_body() #define.
  It cleans the static inline function decls up nicely.  Does it also
restore the Emacs c-mode.el
  compatibility?  If this isn't what bothers emacs, please explain, and I'll
try to code around it.
  (Please understand that I haven't used emacs in any serious way for 15
years, 
   when I discovered nedit :-)  
  
MBARI5:
  Your version avoids the small cost of the alloca() when the only needs to
grow by a small amount.
  Very nice.

- brent


Nobuyoshi Nakada-2 wrote:
> 
> Hi,
> 
> Can't you make patches against the head of stable branch?
> 
> Current status:
> 
> MBARI1: already merged except for a new method.
> 
> MBARI2: backported stack-rewind at thread creation from old
> 	1.9, so I think this patch is no longer needed.
> 
> MBARI4: your patch makes Emacs c-mode.el confused.
> 	<http://www.atdot.net/sp/readonly/rb_eval_split> is
> 	more c-mode.el friendly.
> 
> MBARI5: already merged.
> 
> And could you separate new features from bug fixes?
> 
> -- 
> Nobu Nakada
> 
> 
> 

-- 
View this message in context: http://www.nabble.com/-ruby-core%3A19846---Bug--744--memory-leak-in-callcc--tp20447794p21579583.html
Sent from the ruby-core mailing list archive at Nabble.com.