From: Charles Oliver Nutter Date: 2009-01-21T03:39:09+09:00 Subject: [ruby-core:21474] Re: Supporting Thread.critical=with native threads Paul Brannan wrote: > On Tue, Jan 20, 2009 at 02:52:46AM +0900, Charles Oliver Nutter wrote: >> I suppose we can volunteer JRuby as a guinea pig for this new definition >> of critical=, and see how it goes. JRuby 1.1.7 will implement critical= >> as a global mutex. We shall see how it goes :) > > Will this be on or off by default? It sounds dangerous, in that it > could silently break code. Seems like it would be better to disable > critical= altogether and require users to adapt. It would be on by default; as with many other features, I think implementing the 90% case and documenting how critical= is supposed to officially work in JRuby would be better for now than a hard break. And remember that even currently it's not 100% since it doesn't guarantee other threads won't run for at least a little while before stopping. So we're just making that behavior official and standard in JRuby, since it's the best we can do. - Charlie