From: Yehuda Katz <wycats@...>
Date: 2009-01-18T16:26:19+09:00
Subject: [ruby-core:21399] Proposal: Module#copy_method

--000e0cd2557889b8260460bcbd4e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I'd like it to be possible to copy methods from one module to another. The
rationale is that this feature would make it possible to modify existing
methods without being forced to resort to aliasing. Here's an implementation
that works on 1.8 and 1.9:
static VALUE copy_method(VALUE self, VALUE klass, VALUE symbol) {
  ID id = rb_to_id(symbol);
  NODE *node = NULL;
  st_table *other_method_table = RCLASS(klass)->m_tbl;
  st_table *method_table = RCLASS(self)->m_tbl;

  if(st_lookup(other_method_table, id, (void *)&node)) {
    st_insert(method_table, (st_data_t)id, (st_data_t)node);
    return (Qtrue);
  } else {
    rb_raise(rb_eRuntimeError, "No such method `%s' on %s", rb_id2name(id),
STR2CSTR(rb_mod_name(klass)));
  }
}

void Init_copy_method() {
  VALUE c = rb_cObject;
  c = rb_const_get(c,rb_intern("Module"));
  rb_define_method(c, "copy_method", copy_method, 2);
}

And the ruby code:

module TrackAddedMethods
  def method_added(meth)
    @__added_methods ||= []
    @__added_methods << meth
  end

  def __added_methods
    @__added_methods
  end
end

class Module
  def __move_to_module(*meth_names)
    me = self
    mod = Module.new do
      meth_names.each do |name|
        copy_method me, name
      end
    end
    meth_names.each do |name|
      remove_method name
    end
    include mod
  end

  def chain(&blk)
    mod = Module.new do
      extend TrackAddedMethods
    end
    mod.class_eval(&blk)
    __move_to_module(*mod.__added_methods)
    include mod
  end
end

It would be used like:

class Bar
  def foo
    1
  end

  chain do
    def foo
      super + 1
    end
  end
end

This particular Ruby implementation is just one option, but the point is
that having the generic ability to move methods around would be powerful.

-- 
Yehuda Katz
Developer | Engine Yard
(ph) 718.877.1325

--000e0cd2557889b8260460bcbd4e
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I&#39;d like it to be possible to copy methods from one module to another. =
The rationale is that this feature would make it possible to modify existin=
g methods without being forced to resort to aliasing. Here&#39;s an impleme=
ntation that works on 1.8 and 1.9:<div>
<br></div><div><div>static VALUE copy_method(VALUE self, VALUE klass, VALUE=
 symbol) {</div><div>&nbsp;&nbsp;ID id =3D rb_to_id(symbol);</div><div>&nbs=
p;&nbsp;NODE *node =3D NULL;</div><div>&nbsp;&nbsp;st_table *other_method_t=
able =3D RCLASS(klass)-&gt;m_tbl;</div>
<div>&nbsp;&nbsp;st_table *method_table =3D RCLASS(self)-&gt;m_tbl;</div><d=
iv><br></div><div>&nbsp;&nbsp;if(st_lookup(other_method_table, id, (void *)=
&amp;node)) {</div><div>&nbsp;&nbsp; &nbsp;st_insert(method_table, (st_data=
_t)id, (st_data_t)node);</div><div>
&nbsp;&nbsp; &nbsp;return (Qtrue);</div><div>&nbsp;&nbsp;} else {</div><div=
>&nbsp;&nbsp; &nbsp;rb_raise(rb_eRuntimeError, &quot;No such method `%s&#39=
; on %s&quot;, rb_id2name(id), STR2CSTR(rb_mod_name(klass)));</div><div>&nb=
sp;&nbsp;}</div><div>}</div><div><br></div><div>
<div>void Init_copy_method() {</div><div>&nbsp;&nbsp;VALUE c =3D rb_cObject=
;</div><div>&nbsp;&nbsp;c =3D rb_const_get(c,rb_intern(&quot;Module&quot;))=
;</div><div>&nbsp;&nbsp;rb_define_method(c, &quot;copy_method&quot;, copy_m=
ethod, 2);</div><div>}</div><div>
<br></div><div>And the ruby code:</div><div><br></div><div><div>module Trac=
kAddedMethods &nbsp;</div><div>&nbsp;&nbsp;def method_added(meth)</div><div=
>&nbsp;&nbsp; &nbsp;@__added_methods ||=3D []</div><div>&nbsp;&nbsp; &nbsp;=
@__added_methods &lt;&lt; meth</div><div>&nbsp;&nbsp;end</div>
<div>&nbsp;&nbsp;</div><div>&nbsp;&nbsp;def __added_methods</div><div>&nbsp=
;&nbsp; &nbsp;@__added_methods</div><div>&nbsp;&nbsp;end</div><div>end</div=
></div><div><br></div><div>class Module</div><div><div>&nbsp;&nbsp;def __mo=
ve_to_module(*meth_names)</div><div>&nbsp;&nbsp; &nbsp;me =3D self</div>
<div>&nbsp;&nbsp; &nbsp;mod =3D Module.new do</div><div>&nbsp;&nbsp; &nbsp;=
 &nbsp;meth_names.each do |name|</div><div>&nbsp;&nbsp; &nbsp; &nbsp; &nbsp=
;copy_method me, name</div><div>&nbsp;&nbsp; &nbsp; &nbsp;end</div><div>&nb=
sp;&nbsp; &nbsp;end</div><div>&nbsp;&nbsp; &nbsp;meth_names.each do |name|<=
/div><div>&nbsp;&nbsp; &nbsp; &nbsp;remove_method name</div>
<div>&nbsp;&nbsp; &nbsp;end</div><div>&nbsp;&nbsp; &nbsp;include mod</div><=
div>&nbsp;&nbsp;end</div><div>&nbsp;&nbsp;</div><div>&nbsp;&nbsp;def chain(=
&amp;blk)</div><div>&nbsp;&nbsp; &nbsp;mod =3D Module.new do</div><div>&nbs=
p;&nbsp; &nbsp; &nbsp;extend TrackAddedMethods</div><div>&nbsp;&nbsp; &nbsp=
;end</div><div>&nbsp;&nbsp; &nbsp;mod.class_eval(&amp;blk)</div>
<div>&nbsp;&nbsp; &nbsp;__move_to_module(*mod.__added_methods)</div><div>&n=
bsp;&nbsp; &nbsp;include mod</div><div>&nbsp;&nbsp;end</div><div>end</div><=
div><br></div><div>It would be used like:</div><div><br></div><div><div>cla=
ss Bar</div><div>&nbsp;&nbsp;def foo</div><div>
&nbsp;&nbsp; &nbsp;1</div><div>&nbsp;&nbsp;end</div><div>&nbsp;&nbsp; &nbsp=
;</div><div>&nbsp;&nbsp;chain do</div><div>&nbsp;&nbsp; &nbsp;def foo</div>=
<div>&nbsp;&nbsp; &nbsp; &nbsp;super + 1</div><div>&nbsp;&nbsp; &nbsp;end</=
div><div>&nbsp;&nbsp;end</div><div>end</div></div></div><div><br></div></di=
v>This particular Ruby implementation is just one option, but the point is =
that having the generic ability to move methods around would be powerful.</=
div>
<div><br>-- <br>Yehuda Katz<br>Developer | Engine Yard<br>(ph) 718.877.1325=
<br>
</div>

--000e0cd2557889b8260460bcbd4e--