From: Rocky Bernstein Date: 2009-01-14T02:22:07+09:00 Subject: [ruby-core:21314] debug.rb (Was Re: Current status of 1.9.1 RC2) --0015174bde466036c004606079f4 Content-Type: multipart/alternative; boundary=0015174bde466036ba04606079f2 --0015174bde466036ba04606079f2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit _ wanabe suggests a patch that seems to address not showing the location inside debug.rb. Is there a problem with this? If so, a more general solution is to add into the trace hook a mechanism for ignoring specific frames or code and that's what I've been experimenting with in a rewriteof the Python debugger. So far, it seems to be a win.As for the other problems -- not showing the source code and showing negative line numbers -- that's pretty easily fixed too. The attached patch should do it. However that said, debug.rb is kind of weak in a number of areas, but redoing it only seems interesting after instruction trap replacement is in place. Comments? On Tue, Jan 13, 2009 at 8:07 AM, Yugui (Yuki Sonoda) wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi folks, > > I have a plan to release Ruby 1.9.1 RC2 on Jan 15 and we must release > 1.9.1 on Jan 25. But there are 23 issues. > > == #616 instance_eval and Module#to_s > < ko1 > Scope for contants in instance_eval or module_eval is changed in 1.9. > The remaining problem is why the class is not named. > > == #847, #848 debug.rb > This is a result of a bit of feature change in set_trace_func. This is > difficult to fix. > Will anyone fix debug.rb? We need help. > > == #865 patch for Rake > < Jim Weirich > Is the patch correct? Then, please apply it. > > == #866 manpages for RubyGems > < Jim Weirich > *I asked you about the license for the manpages 4 times and sent the > manpages to you.* > > Can I distribute the pages with Ruby under GPL and Ruby's license? Or > is the license unclear? Then I'll give up the idea of distributing them . > > > == #886 GC from blocking region > < ko1 > Is this fixed in r21438 and r21441? > > == #888 zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on > Windows > Is this still reproducible? > > == #935 child process forked from child thread does not call ruby_cleanup > < mame > Is this still reproducible? Or close the ticket. > I cannot reproduce. > > == #940 ruby/config.h:1:1: warning: "PACKAGE_NAME" redefined > Can I regard this as rejected? > > == #942 Build fails on IA-32 Linux with gcc 4.3.2 > Is this still reproducible? > > == #947 Signal handler block is never called when the program is too short > < ko1 > Show me your plan to fix this issue. Or should I give up to fix this by > 1.9.1? > > == #948 dl: cannot pass double value correctly on all x86_64 systems > I want to release 1.9.1 with this bug because dl2 x86_64 support seems > to be too difficult to fix. Any idea? > > == #956 Encoding: nl_langinfo(CODESET) on cygwin 1.5 always returns > US-ASCII > < nobu > Can I regard this as fixed? Then close the ticket. > > == #957 Cannot build in OSX 10.5.6 using gcc4.0.1 or gcc4.2 due to issue > with readline.h > < Kouji Takao > I cannot reproduce this issue on OSX 10.5.6 with gcc 4.0.1. > Can you reproduce this? > > == #967 Results of const_missing are being cached incorrectly > < ko1 > Show me your plan to fix this issue. > > == #968 trap may fail to handle signals > < ko1 > What do you think about mame's patch? > > == #975 ruby curses extension does not support multibyte characters > < matz > Do you intend to fix this by 1.9.1? > > == #981 String#encode() keeps invalid bytes when converting to US-ASCII > Any idea? > > == #984 Test::Unit::Assertions#assert_match double counts number of > assertions > I'm working on this issue. > > == #985 profile lib + iterator => 'NULL pointer given' (ArgumentError) > < ko1 > Show me your plan to fix this issue. > > > == #1002 r21312 causes test failures on RubyGems > < Eric Hodel, nobu > > I think r21312 broke an assumption for Rubygems' working correctly. > What do you think? > > == #1003 autoload test failed on OpenSolaris > < Dae San, nobu > You are working on this issue? right? > > == #1004 Encoding related test failure on OpenSolaris > < nobu > Can I regard this issue as rejected? > > > > Regards, > > - -- Yugui > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (Darwin) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAklskicACgkQOXzH5JLb/AWegwCfRtIZ5JDskIn543mv52ps9qFu > 1oEAn2zzJtWkRBM3UESTcCWCALs2eSiV > =MuTv > -----END PGP SIGNATURE----- > > --0015174bde466036ba04606079f2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
_ wanabe suggests a patch that seems to address= not showing the location inside debug.rb. Is there a problem with this?&nb= sp;

If so, a more general solution is to add= into the trace hook a mechanism for ignoring specific frames or code and t= hat's what I've been experimenting with in a rewrite of the Python debugg= er. So far, it seems to be a win.

As for the other problems --  not showing the source code and showing = negative line numbers -- that's pretty easily fixed too. The attached p= atch should do it.

However that said, debug.rb is kind of weak in a = number of areas, but redoing it only seems interesting after instruction tr= ap replacement is in place.  Comments?

On Tue, Jan 13, 2009 at 8:07 AM, Yugui (Yuki= Sonoda) <yugui@yugui.jp> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi folks,

I have a plan to release Ruby 1.9.1 RC2 on Jan 15 and we must release
1.9.1 on Jan 25. But there are 23 issues.

=3D=3D #616 instance_eval and Module#to_s
< ko1
Scope for contants in instance_eval or module_eval is changed in 1.9.
The remaining problem is why the class is not named.

=3D=3D #847, #848 debug.rb
This is a result of a bit of feature change in set_trace_func. This is
difficult to fix.
Will anyone fix debug.rb?  We need help.

=3D=3D #865 patch for Rake
< Jim Weirich
Is the patch correct?  Then, please apply it.

=3D=3D #866 manpages for RubyGems
< Jim Weirich
*I asked you about the license for the manpages 4 times and sent the
manpages to you.*

Can I distribute the pages with Ruby under GPL and Ruby's license? &nbs= p;Or
is the license unclear?  Then I'll give up the idea of distributin= g them .


=3D=3D #886 GC from blocking region
< ko1
Is this fixed in r21438 and r21441?

=3D=3D #888 zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on=
Windows
Is this still reproducible?

=3D=3D #935 child process forked from child thread does not call ruby_clean= up
< mame
Is this still reproducible?  Or close the ticket.
I cannot reproduce.

=3D=3D #940 ruby/config.h:1:1: warning: "PACKAGE_NAME" redefined<= br> Can I regard this as rejected?

=3D=3D #942 Build fails on IA-32 Linux with gcc 4.3.2
Is this still reproducible?

=3D=3D #947 Signal handler block is never called when the program is too sh= ort
< ko1
Show me your plan to fix this issue. Or should I give up to fix this by
1.9.1?

=3D=3D #948 dl: cannot pass double value correctly on all x86_64 systems I want to release 1.9.1 with this bug because dl2 x86_64 support seems
to be too difficult to fix.  Any idea?

=3D=3D #956 Encoding: nl_langinfo(CODESET) on cygwin 1.5 always returns US-= ASCII
< nobu
Can I regard this as fixed?  Then close the ticket.

=3D=3D #957 Cannot build in OSX 10.5.6 using gcc4.0.1 or gcc4.2 due to issu= e
with readline.h
< Kouji Takao
I cannot reproduce this issue on OSX 10.5.6 with gcc 4.0.1.
Can you reproduce this?

=3D=3D #967 Results of const_missing are being cached incorrectly
< ko1
Show me your plan to fix this issue.

=3D=3D #968 trap may fail to handle signals
< ko1
What do you think about mame's patch?

=3D=3D #975 ruby curses extension does not support multibyte characters
< matz
Do you intend to fix this by 1.9.1?

=3D=3D #981 String#encode() keeps invalid bytes when converting to US-ASCII=
Any idea?

=3D=3D #984 Test::Unit::Assertions#assert_match double counts number of
assertions
I'm working on this issue.

=3D=3D #985 profile lib + iterator =3D> 'NULL pointer given' (Ar= gumentError)
< ko1
Show me your plan to fix this issue.


=3D=3D #1002 r21312 causes test failures on RubyGems
< Eric Hodel, nobu

I think r21312 broke an assumption for Rubygems' working correctly.
What do you think?

=3D=3D #1003 autoload test failed on OpenSolaris
< Dae San, nobu
You are working on this issue? right?

=3D=3D #1004 Encoding related test failure on OpenSolaris
< nobu
Can I regard this issue as rejected?



Regards,

- -- Yugui <yugui@yu= gui.jp>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklskicACgkQOXzH5JLb/AWegwCfRtIZ5JDskIn543mv52ps9qFu
1oEAn2zzJtWkRBM3UESTcCWCALs2eSiV
=3DMuTv
-----END PGP SIGNATURE-----




--0015174bde466036ba04606079f2-- --0015174bde466036c004606079f4 Content-Type: application/mbox; name="debug.patch" Content-Disposition: attachment; filename="debug.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fpwtvx2j1 SW5kZXg6IGxpYi9kZWJ1Zy5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaWIvZGVidWcucmIJKHJldmlzaW9u IDIxNDk3KQorKysgbGliL2RlYnVnLnJiCSh3b3JraW5nIGNvcHkpCkBAIC01OTEsOCArNTkxLDEx IEBACiAgIGVuZAogCiAgIGRlZiBkaXNwbGF5X2xpc3QoYiwgZSwgZmlsZSwgbGluZSkKLSAgICBz dGRvdXQucHJpbnRmICJbJWQsICVkXSBpbiAlc1xuIiwgYiwgZSwgZmlsZQotICAgIGlmIGxpbmVz ID0gU0NSSVBUX0xJTkVTX19bZmlsZV0gYW5kIGxpbmVzICE9IHRydWUKKyAgICBpZiBub3QobGlu ZXMgPSBTQ1JJUFRfTElORVNfX1tmaWxlXSkgb3IgbGluZXMgPT0gdHJ1ZQorICAgICAgbGluZXMg PSBiZWdpbiBGaWxlLm9wZW4oZmlsZSkucmVhZGxpbmVzKCkgcmVzY3VlIHRydWUgZW5kCisgICAg ZW5kCisgICAgaWYgbGluZXMgIT0gdHJ1ZQorICAgICAgc3Rkb3V0LnByaW50ZiAiWyVkLCAlZF0g aW4gJXNcbiIsIFsxLGJdLm1heCwgZSwgZmlsZQogICAgICAgYi51cHRvKGUpIGRvIHxufAogCWlm IG4gPiAwICYmIGxpbmVzW24tMV0KIAkgIGlmIG4gPT0gbGluZQpAQCAtODk4LDEwICs5MDEsMTAg QEAKIAogc3Rkb3V0LnByaW50ZiAiRGVidWcucmJcbiIKIHN0ZG91dC5wcmludGYgIkVtYWNzIHN1 cHBvcnQgYXZhaWxhYmxlLlxuXG4iCitSdWJ5Vk06Okluc3RydWN0aW9uU2VxdWVuY2UuY29tcGls ZV9vcHRpb24gPSB7CisgIHRyYWNlX2luc3RydWN0aW9uOiB0cnVlCit9CiBzZXRfdHJhY2VfZnVu YyBwcm9jIHsgfGV2ZW50LCBmaWxlLCBsaW5lLCBpZCwgYmluZGluZywga2xhc3MsICpyZXN0fAog ICBERUJVR0dFUl9fLmNvbnRleHQudHJhY2VfZnVuYyBldmVudCwgZmlsZSwgbGluZSwgaWQsIGJp bmRpbmcsIGtsYXNzCiB9Ci1SdWJ5Vk06Okluc3RydWN0aW9uU2VxdWVuY2UuY29tcGlsZV9vcHRp b24gPSB7Ci0gIHRyYWNlX2luc3RydWN0aW9uOiB0cnVlCi19CiBlbmQK --0015174bde466036c004606079f4--