From: Chauk-Mean PROUM <redmine@...>
Date: 2008-12-31T18:00:42+09:00
Subject: [ruby-core:21014] [Bug #888] zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows

Issue #888 has been updated by Chauk-Mean PROUM.


@Luis

> Gregory Brown offered backport the zlib tests from 1.9 to 1.8 in [ruby-core:20602]
> Maybe those can help pinpoint the root of the problem.

I'm running ruby-1.9.1 from the beginning and as I indicated in a previous message, all zlib tests pass successfully.

@Eric

>I'm not sure where the bug actually exists, but I'd really like to see  
>the bug fixed.  I'm fairly certain the bug doesn't exist in RubyGems  
>and I'm tired of having to continually apply bandaids to RubyGems.

I'm sorry to "have accused" Rubygems for this bug. But the zlib tests are OK.
May be there is a missing test case in zlib ?

@Eric and @Yasuhiro

> For what it's worth, I'd really like to see the root cause of this bug  
> fixed so this method can be returned to a simpler form:
>
> def zipped_stream(entry)
>    zis = Zlib::GzipReader.new entry
>    dis = zis.read
>    is = StringIO.new(dis)
> ensure
>    zis.finish if zis
> end
>
> Or even:
>
> def zipped_stream(entry)
>    Zlib::GzipReader.new entry
> end

Yes, the two forms work also fine for me.
The second looks really better (simple is better :-)).

Chauk-Mean.

----------------------------------------
http://redmine.ruby-lang.org/issues/show/888

----------------------------------------
http://redmine.ruby-lang.org