From: James Gray Date: 2008-10-25T09:57:07+09:00 Subject: [ruby-core:19493] Re: [ruby-dev:36896] * lib/csv.rb: Failure test_inspect_is_ascii_8bit_encoded(TestCSVRow) On Oct 24, 2008, at 1:52 AM, Martin Duerst wrote: > [forwarded from ruby-dev to ruby-core, with translation(t)/ > comments(c)] Thanks so much for doing this. You are really helping us bridge the gap between the two communities. > At 13:42 08/10/24, TAKANO Mitsuhiro wrote: >> 高野です。 >> > > (t) This is Takano. This is a patch regarding > >> ---- >> 1) Failure: >> test_inspect_is_ascii_8bit_encoded(TestCSVRow) >> [/home/takano/ruby/test/csv/test_ >> row.rb:300]: >> <"ASCII-8BIT"> expected but was >> <"US-ASCII">. >> ---- >> >> についてのパッチです。 >> >> # ほんとにこんなんでいいのかな・・・ >> # 文字コード周りに詳しい方教えてくださいっ。m(_ _)m > > (t) I'm not sure this is the right thing to do,... > (t) Somebody who knows about character encoding, please help. > > (c) The patch below doesn't look like something we want > programmers to have to do. Either we need some change > in the test, or we need some some fix in the logic. > "US-ASCII" is in all respecs a subset of "ASCII-8BIT", > so things will work just fine. I loosened the tests to check for an ASCII compatible Encoding instead. Hopefully this fixes the issue for everyone, but please let me know if that's not the case. James Edward Gray II