From: SASADA Koichi <ko1@...>
Date: 2008-09-24T07:28:27+09:00
Subject: [ruby-core:18823] Re: miniunit added

SASADA Koichi wrote:
> Ryan Davis wrote:
>> I've replaced test/unit with miniunit in order to meet the feature
>> freeze deadline. There are some extra failures in rdoc that Eric Hodel
>> is going to look into and fix. Otherwise it looks like failure parity is
>> fairly close.
>>
>> I had to comment out 3 tests in order to get my test runs to complete. I
>> didn't commit these changes. They would hang and the backtrace was
>> incredibly deep but looked like it might be thread deadlock while
>> handling a sigbus? I'm not sure but I'll look into it more later.
> 
> ko1@vd:~/ruby/build$ make test-all
> ./miniruby -I../trunk/lib -I.ext/common -I./-
> -r../trunk/ext/purelib.rb  ../trunk/runruby.rb --extout=.ext  --
> "../trunk/test/runner.rb" --basedir="../trunk/test" --runner=console
> Loaded suite ../trunk/test/runner
> Started
> 
> Finished in 0.001032 seconds.
> 
> 0 tests, 0 assertions, 0 failures, 0 errors
> 
> ... why?
> 

Following patch works fine on my environment

Index: test/runner.rb
===================================================================
--- test/runner.rb	(��������������� 19505)
+++ test/runner.rb	(���������������)
@@ -6,8 +6,12 @@
 Version = rcsid[2].scan(/\d+/).collect!(&method(:Integer)).freeze
 Release = rcsid[3].freeze

+testdir = File.dirname(__FILE__)
+
 # not sure why these are needed now... but whatever
-$:.push(*Dir["test/*"].find_all { |path| File.directory? path })
+$:.push(*Dir[File.join(testdir, '*')].find_all{|path|
+  File.directory? path
+})

 class Module
   def tu_deprecation_warning old, new = nil, kaller = nil
@@ -15,6 +19,7 @@
   end
 end

-(Dir["test/test_*.rb"] + Dir["test/**/test_*.rb"]).each do |test|
+(Dir[File.join(testdir, "test_*.rb")] +
+ Dir[File.join(testdir, "**/test_*.rb")]).each do |test|
   require test
 end


-- 
// SASADA Koichi at atdot dot net