[ruby-core:17442] Re: patches for tests of rubygems

Hi Eric,

2008/6/26 Eric Hodel <[e-mail]>:
> Thank you, I have committed to RubyGems and updated ruby trunk.

In my environment, two types of errors are still output.


| $ make test-all TESTS=rubygems
| ./miniruby -I./lib -I.ext/common -I./- -r./ext/purelib.rb
./runruby.rb --extout=.ext  -- "./test/runner.rb" --basedir="./test"
--runner=console rubygems
| Gem::Indexer tests are being skipped.  Install builder gem.
| Loaded suite rubygems
| Started
| ........................................................................................................................................................................................................................................F.....E..........................................E.E..E.E.......................................................................................................................................................................................................................................................................................................................................EEEEE....................................................
| Finished in 24.780373807 seconds.
|
|   1) Failure:
| test_self_build_fail(TestGemExtConfigureBuilder)
[/home/mame/work/ruby19/ruby/test/rubygems/test_gem_ext_configure_builder.rb:59]:
| <"configure failed:\n\nsh ./configure
--prefix=/tmp/test_rubygems_23735/prefix\nsh: ./configure:
そのようなファイルやディレクトリはありません\n"> expected to be =~
| </configure failed:
|
| sh\ \.\/configure\ \-\-prefix=\/tmp\/test_rubygems_23735\/prefix
| .*?: (?-mix:(\.\/configure: No such file or directory)|(Can't open
\.\/configure))
| />.


Because of my locale, Japanese error message is output.
I think that a test should basically not depend on such a message.

Index: test/rubygems/test_gem_ext_configure_builder.rb
===================================================================
--- test/rubygems/test_gem_ext_configure_builder.rb	(revision 17719)
+++ test/rubygems/test_gem_ext_configure_builder.rb	(working copy)
@@ -47,7 +47,7 @@
       end
     end

-    shell_error_msg = %r{(\./configure: No such file or
directory)|(Can't open \./configure)}
+    shell_error_msg = %r{(\./configure:)|(Can't open \./configure)}
     sh_prefix_configure = "sh ./configure --prefix="

     expected = %r(configure failed:


|   2) Error:
| test_class_build(TestGemExtRakeBuilder):
| Gem::InstallError: rake failed:
|
| /home/mame/work/ruby19/local/bin/ruby mkrf_conf.rb
|
| rake RUBYARCHDIR=/tmp/test_rubygems_23735/prefix
RUBYLIBDIR=/tmp/test_rubygems_23735/prefix
| sh: rake: command not found
|
|     /home/mame/work/ruby19/ruby/lib/rubygems/ext/builder.rb:51:in `run'
|     /home/mame/work/ruby19/ruby/lib/rubygems/ext/rake_builder.rb:21:in `build'
|     /home/mame/work/ruby19/ruby/test/rubygems/test_gem_ext_rake_builder.rb:31:in
`block in test_class_build'
|     /home/mame/work/ruby19/ruby/test/rubygems/test_gem_ext_rake_builder.rb:29:in
`chdir'
|     /home/mame/work/ruby19/ruby/test/rubygems/test_gem_ext_rake_builder.rb:29:in
`test_class_build'


As I told you, the test fails because it tries to execute rake
on the environment variable PATH.
I think an absolute path to rake must be specified.

Index: runruby.rb
===================================================================
--- runruby.rb	(revision 17719)
+++ runruby.rb	(working copy)
@@ -46,6 +46,7 @@
 config["bindir"] = abs_archdir
 ENV["RUBY"] = File.expand_path(ruby)
 ENV["PATH"] = [abs_archdir, ENV["PATH"]].compact.join(File::PATH_SEPARATOR)
+ENV["rake"] = ENV["RUBY"] + " " + File.join(abs_archdir, "bin", "rake")

 if pure
   libs << File.expand_path("ext", srcdir) << "-"


(snip)
| 673 tests, 1934 assertions, 1 failures, 10 errors
| make: *** [test-all] エラー 1


Other failures and errors are removed by above two patches.

-- 
Yusuke ENDOH <[e-mail]>