From: Tadashi Saito <shiba@...2.accsnet.ne.jp>
Date: 2007-12-25T11:54:13+09:00
Subject: Re: Many external symbols _without_ prefix in libruby object file

Hello,

IMHO, externded function'name that begin with "is_" is not a good nor
an elegant name.

I substituted "is_ruby_native_thread" with "rb_is_native_thread,"
but other better name may (or may not) exist.

Index: thread.c
===================================================================
--- thread.c	(revision 14640)
+++ thread.c	(working copy)
@@ -3119,7 +3119,7 @@
 }
 
 int
-is_ruby_native_thread(void)
+rb_is_native_thread(void)
 {
     rb_thread_t *rb_thread_check_ptr(rb_thread_t *ptr);
     rb_thread_t *th = ruby_thread_from_native();
Index: ext/tk/tcltklib.c
===================================================================
--- ext/tk/tcltklib.c	(revision 14640)
+++ ext/tk/tcltklib.c	(working copy)
@@ -1298,7 +1298,7 @@
 
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on eventloop_sleep()");
     }
 #endif
@@ -1310,7 +1310,7 @@
 
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on eventloop_sleep()");
     }
 #endif
@@ -2457,7 +2457,7 @@
 
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on tcl_protect()");
     }
 #endif
@@ -2866,7 +2866,7 @@
     }
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on ip_ruby_eval()");
     }
 #endif
@@ -3015,7 +3015,7 @@
     }
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on ip_ruby_eval()");
     }
 #endif
@@ -3194,7 +3194,7 @@
     Tcl_Preserve(interp);
 #if 0
 #ifdef HAVE_NATIVETHREAD
-    if (!is_ruby_native_thread()) {
+    if (!rb_is_native_thread()) {
         rb_bug("cross-thread violation on ip_ruby_eval()");
     }
 #endif
@@ -5964,7 +5964,7 @@
     if (rb_safe_level() != q->safe_level) {
 #if 0
 #ifdef HAVE_NATIVETHREAD
-        if (!is_ruby_native_thread()) {
+        if (!rb_is_native_thread()) {
             rb_bug("cross-thread violation on eval_queue_handler()");
         }
 #endif
@@ -8384,7 +8384,7 @@
 
     /* if ruby->nativethread-supprt and tcltklib->doen't, 
        the following will cause link-error. */
-    is_ruby_native_thread();
+    rb_is_native_thread();
 
     /* --------------------------------------------------------------- */
 


-- 
Tadashi Saito