From: "Earlopain (Earlopain _) via ruby-core" Date: 2026-10-07T11:02:25+00:00 Subject: [ruby-core:126973] [Ruby Feature#22379] Remove prism mismatch warning from `#syntax_tree` Issue #22379 has been updated by Earlopain (Earlopain _). Currently it loudly returns the correct node and I would simply always ignore this warning because it is just noise. Should I ever hit the case where it is actually different I would never know. On `Ruby::Prism`, I believe that approach has already been somewhat discussed in the original issue with `Ruby::Node`. I'm not a big fan of duplicating the definitions, @kddnewton also didn't favor it https://bugs.ruby-lang.org/issues/21795#note-10 An idea I had was that prism has snapshot tests that compare node output. Currently they don't include node ids, so any change could in theory change them for all ruby versions. If we add node ids to the snapshots, we can guarantee that for a specific ruby major/minor version, the node ids won't change. If prism wants to change node_ids, it would only be able to do so for the next ruby version so that previous versions get the expected node ids. In my mind, that would alleviate the problem massively. Thoughts? ---------------------------------------- Feature #22379: Remove prism mismatch warning from `#syntax_tree` https://bugs.ruby-lang.org/issues/22379#change-119370 * Author: Earlopain (Earlopain _) * Status: Open ---------------------------------------- #21795 added `#syntax_tree` for a few objects. Currently it is implemented in a way that uses the prism gem, using node_id. Because it is theoretically possible that node_ids from the internal cruby version of prism don't match with the node_ids from the installed prism gem, a warning is emitted when the two versions don't match: ```rb def x = nil pp method(:x).syntax_tree # => syntax_tree: a prism gem other than the default gem is loaded; the result may not correspond exactly to the compiled code # => @ DefNode (location: (1,0)-(1,11)) # ... ``` That this version-mismatch happens is basically a given. As soon as the user has prism in their lockfile for any reason it will be triggered. When I encounter a warning I assume that I have to make some change in the code to avoid it but there is nothing realistic for me to do, except to stop using the method alltogether. The warning is verbose-only. However it's good practise to run test suites with warnings enabled to keep up on deprecations, so even there it does not fit. I would like this warning to become documentation only for the above reasons. @eregon also suggested to only warn when we can prove that the node_id doesn't match. That should be possible as well, since we have the code location from the iseq and can check if the node we found via prism lines up. However, that doesn't guarantee that the contents of the node are also the same. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- ruby-core@ml.ruby-lang.org To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/