[ruby-core:123247] [Ruby Bug#21402] ruby2_keywords affects methods/procs with post arguments
From:
"nagachika (Tomoyuki Chikanaga) via ruby-core" <ruby-core@...>
Date:
2025-09-14 04:13:27 UTC
List:
ruby-core #123247
Issue #21402 has been updated by nagachika (Tomoyuki Chikanaga).
Backport changed from 3.2: REQUIRED, 3.3: REQUIRED, 3.4: DONE to 3.2: REQUIRED, 3.3: DONE, 3.4: DONE
ruby_3_3 commit:e39a0a19c03fbb37d1c9d1e050bb551dccfc11c6 merged revision(s) commit:ce849d565bf6aae8e0179fffb04eb1f665f17347, commit:acb29f7fa1497463ed3bdd65549ef20b61beda64.
----------------------------------------
Bug #21402: ruby2_keywords affects methods/procs with post arguments
https://bugs.ruby-lang.org/issues/21402#change-114580
* Author: jeremyevans0 (Jeremy Evans)
* Status: Closed
* Backport: 3.2: REQUIRED, 3.3: DONE, 3.4: DONE
----------------------------------------
I believe this is an oversight. We forgot to consider post arguments during the development of `ruby2_keywords`. I believe we should not allow `ruby2_keywords` on methods/procs with post arguments. Example:
```ruby
def a(*c, **kw) [c, kw] end
def b(*a, b) a(*a, b) end
ruby2_keywords(:b)
b({foo: 1}, bar: 1)
# Currently: [[{foo: 1}], {bar: 1}]
# Expected: [[{foo: 1}, {bar: 1}], {}]
```
I think the current behavior is unexpected and undesired, because instead of flagging the last element in the splat array, it flags a post argument.
I've submitted a pull request to fix this: https://github.com/ruby/ruby/pull/13475
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/