[ruby-core:121288] [Ruby master Bug#21146] VM_ASSERT(expr) gives bad bug report results when another ractor fails an assertion during printing of report

Issue #21146 has been updated by ko1 (Koichi Sasada).


Your patch uses `RB_VM_LOCK_ENTER_NO_BARRIER` but it should block normal use of `rb_bug()` (using `rb_bug()` is irregular case though).
So I think it should use simpler mechanism to synchronize `rb_bug()` calling. For example, introducing a global variable to avoid multiple `rb_bug()` calls.

(btw `VM_ASSERT()` calls `rb_bug()` if `RUBY_DEBUG` (or other macros) is defined, so `rb_bug()` is suitable for the example)

----------------------------------------
Bug #21146: VM_ASSERT(expr) gives bad bug report results when another ractor fails an assertion during printing of report
https://bugs.ruby-lang.org/issues/21146#change-112252

* Author: luke-gru (Luke Gruber)
* Status: Open
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
test.rb:
```ruby
rs = 100.times.map do
  Ractor.new do
    cnt = rand 3
    cnt += 1 if cnt.zero?
    sleep cnt
    100.times do |i|
      if i != 0 && i % 50 == 0
        Ractor.fail_assert
      end
    end
  end
end
```

ractor.rb:

```ruby
def self.fail_assert
  __builtin_cexpr! %q{
    VM_ASSERT(0), Qfalse
  }
end
```

> make run

I would like to be able to see the bug report for the first failed assertion, without any output from the other ractors.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/