[ruby-core:121231] [Ruby master Bug#21159] `Module#set_temporary_name` should freeze given name
From:
"ufuk (Ufuk Kayserilioglu) via ruby-core" <ruby-core@...>
Date:
2025-03-04 01:07:53 UTC
List:
ruby-core #121231
Issue #21159 has been updated by ufuk (Ufuk Kayserilioglu).
Backport changed from 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED, 3.4: REQUIRED to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED, 3.4: DONE
ruby_3_4 commit:ddb73fbd115631e6dec3bdd230c1cfc13027602e.
----------------------------------------
Bug #21159: `Module#set_temporary_name` should freeze given name
https://bugs.ruby-lang.org/issues/21159#change-112181
* Author: ko1 (Koichi Sasada)
* Status: Closed
* Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED, 3.4: DONE
----------------------------------------
I think it is preferable to freeze the name.
So `#set_temporary_name` should copy and freeze the name string.
```ruby
c = Class.new.set_temporary_name(str = +'<c>')
p c #=> <c>
str.upcase!
p c #=> actual: <C>
#=> expected: <c>
p c.name.frozen?
#=> actual: false
#=> expected: true
```
>>From the Ractor's aspect, shareable modules should refer only immutable string.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/