[ruby-core:120338] [Ruby master Feature#20971] Deprecate `rb_path_check`

Issue #20971 has been updated by jeremyevans0 (Jeremy Evans).


>>From looking at the history, `rb_path_check` was originally used by `rb_env path_tainted`, presumably to check whether the PATH environment variable was tainted, so as not to trust it.  That may be why it is in the hash.h header instead of the file.h header, even though it makes no sense in the hash.h header.

`rb_path_check` was used in MJIT, to check for unsafe header files, but that was the last usage I could see in CRuby.  I'm guessing that is a reason it may not have been deprecated/removed when $SAFE/taint was deprecated/removed.

If we can do a gem codesearch for `rb_path_check`, and nothing important comes up, I am in favor of deprecating and then removing it.  I looked through the first 5 pages of GitHub results and nothing of note came up, other than the fact that TruffleRuby does not implement the function.

----------------------------------------
Feature #20971: Deprecate `rb_path_check`
https://bugs.ruby-lang.org/issues/20971#change-111111

* Author: Earlopain (Earlopain _)
* Status: Open
----------------------------------------
With #16131, various code around $SAFE, taint, etc. has been deprecated and removed. GH PR https://github.com/ruby/ruby/pull/2476.

Now, [`rb_path_check`] still exists as part of the public API, with Ruby itself never using or testing it. I believe it should have been deprecated and was simply missed. Should it be deprecated today or is that not worth the effort?

Docs for it are pretty vague: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/include/ruby/internal/intern/hash.h#L289-L297
> This function is mysterious.  What it does is not immediately obvious. Also what it does seems platform dependent.

[`rb_path_check`]: https://github.com/ruby/ruby/blob/33f95d632dce42fac35da29eaed33f0a5a4f0dcb/file.c#L6427



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/