[ruby-core:119667] [Ruby master Bug#20857] Don't change `Hash#inspect` formatting

Issue #20857 has been updated by mame (Yusuke Endoh).


I took a quick look at all the failures of packages starting with "ruby" in https://copr.fedorainfracloud.org/coprs/vondruch/mpb/packages/, and categorized them. Please forgive me if this is not accurate.

* 38 of them seemed to be dependency issues that did not lead to Ruby test execution. I don't think this is Ruby's fault.
* There were 38 failures like `cannot load such file -- base64`. I think is related to gemification.
* There were 13 failures that appeared to be due to `Hash#inspect` incompatibilities. Most of them seemed to be using inspect results for test expectations. rubygem-rspec-expectations seemed to be a bit of a pain, since it is really a gem about test expectations.
* There were 10 that appeared to be affected by the change from backquotes to single quotes in error messages.
* There were 8 that appeared to be due to cucumber incompatibilities and 2 that were due to a change in the default parser for URIs.
* The remaining 18 were not clear. It is possible that one of the above incompatibilities caused the code to behave differently than intended, resulting in an incomprehensible error.

I don't say that the impact of `Hash#inspect` incompatibility is negligible, but I don't think it is significant as a percentage. Also, I can confirm that most of the failures due to `Hash#inspect` could be fixed by modifying the expected values of the test.

Should this ticket be kept alive? I think the re-packaging issue is worth discussing, but I think it should be discussed in another ticket.

```
# 38: maybe dependency issue (Failed to resolve the transaction)
ruby-gnome2
rubygem-actioncable
rubygem-actionpack
rubygem-activerecord
rubygem-activestorage
rubygem-bootsnap
rubygem-bundler_ext
rubygem-cairo
rubygem-cairo-gobject
rubygem-capybara
rubygem-clutter
rubygem-clutter-gstreamer
rubygem-clutter-gtk
rubygem-excon
rubygem-gdk3
rubygem-gdk4
rubygem-gdk_pixbuf2
rubygem-glu
rubygem-goocanvas
rubygem-goocanvas1
rubygem-gtk2
rubygem-gtk3
rubygem-gtksourceview2
rubygem-gtksourceview3
rubygem-importmap-rails
rubygem-jekyll (install issue?)
rubygem-opengl
rubygem-pango
rubygem-poppler
rubygem-rabbit
rubygem-railties
rubygem-rspec-rails
rubygem-rsvg2
rubygem-sass-rails
rubygem-shoulda-matchers
rubygem-vte
rubygem-vte3
rubygem-webkit2-gtk
rubygem-webmock

# 38: gemification
rubygem-abrt: cannot load such file -- syslog
rubygem-activesupport: cannot load such file -- mutex_m
rubygem-asciidoctor: cannot load such file -- base64
rubygem-bson: cannot load such file -- base64
rubygem-coveralls: cannot load such file -- base64
rubygem-em-http-request: cannot load such file -- base64
rubygem-em-websocket: cannot load such file -- base64
rubygem-fakefs: cannot load such file -- csv
rubygem-fog-core: cannot load such file -- base64
rubygem-guard-livereload: cannot load such file -- base64
rubygem-httparty: cannot load such file -- csv
rubygem-httpclient: cannot load such file -- mutex_m
rubygem-i18n: cannot load such file -- mutex_m
rubygem-jekyll-asciidoc: cannot load such file -- csv
rubygem-jekyll-feed: cannot load such file -- csv
rubygem-jekyll-git-authors: cannot load such file -- csv
rubygem-jekyll-sass-converter: cannot load such file -- csv
rubygem-jekyll-toc: cannot load such file -- csv
rubygem-net-scp: cannot load such file -- base64
rubygem-net-sftp: cannot load such file -- base64
rubygem-net-ssh: cannot load such file -- base64
rubygem-rack: cannot load such file -- base64
rubygem-rack-protection: cannot load such file -- base64
rubygem-rack-test: cannot load such file -- base64
rubygem-rbvmomi: cannot load such file -- base64
rubygem-rmagick: cannot load such file -- observer
rubygem-rspec-core: cannot load such file -- drb/drb
rubygem-rttool: cannot load such file -- nkf
rubygem-selenium-webdriver: cannot load such file -- base64
rubygem-sinatra: cannot load such file -- base64
rubygem-sprockets: cannot load such file -- base64
rubygem-test-unit: cannot load such file -- csv
rubygem-text: cannot load such file -- csv
rubygem-typhoeus: cannot load such file -- base64
rubygem-webrobots: cannot load such file -- base64
rubygem-websocket: cannot load such file -- base64
rubygem-websocket-driver: cannot load such file -- base64
rubygems: cannot load such file -- base64

# 13: Hash#inspect
rubygem-activejob
rubygem-activemodel
rubygem-contracts
rubygem-asciidoctor
rubygem-formatador
rubygem-haml
rubygem-mocha
rubygem-mustermann (I am not sure)
rubygem-pg
rubygem-rdoc
rubygem-rspec-expectations (A bit difficult)
rubygem-rspec-mocks
rubygem-rspec-support

# 10: backquote->single quote in error message
rubygem-docile
rubygem-factory_bot
rubygem-flexmock
rubygem-minitest4
rubygem-msgpack
rubygem-pry
rubygem-puma
rubygem-require_all
rubygem-ruby-dbus
rubygem-thor

# 8: cucumber?
rubygem-aruba: unknown keywords: :strict, :proc (ArgumentError)
rubygem-cucumber: unknown keywords: :strict, :proc
rubygem-cucumber-wire: unknown keywords: :strict, :proc
rubygem-json_spec: unknown keywords: :strict, :proc (ArgumentError)
rubygem-minitest-around: unknown keywords: :strict, :proc (ArgumentError)
rubygem-nifti: unknown keywords: :strict, :proc (ArgumentError)
rubygem-rake-compiler: unknown keywords: :strict, :proc (ArgumentError)
rubygem-rspec-its: unknown keywords: :strict, :proc (ArgumentError)

# 2: uri
rubygem-cookiejar: uninitialized constant URI::REGEXP
rubygem-websocket: uninitialized constant URI::REGEXP

# 18: unknown
rubygem-actionview: undefined method 'series_url' for #<PolymorphicRoutesTest:0x00007f9e885a94d8>".
rubygem-asciidoctor-pdf: ??? 
rubygem-async_sinatra: uninitialized constant MiniTest (NameError)
rubygem-curb: ???
rubygem-ethon: uninitialized constant LocalhostServer::TimeoutError
rubygem-faraday: cannot load such file -- webmock/rspec
rubygem-globalid: ArgumentError expected but nothing was raised
rubygem-guard: Guard::Guardfile::Evaluator::NoPluginsError error!
rubygem-image_size: ??? Unexpected response
rubygem-memfs: ???
rubygem-puppet-lint: ??? rspec/json_expectations is not available
rubygem-redis-client: cannot load such file -- minitest/autorun (LoadError)
rubygem-ronn-ng: ??? NameError: uninitialized constant RonnTest::FileUtils
rubygem-sass: ???
rubygem-serialport: is deprecated: rb_io_descriptor
rubygem-webrick: uninitialized constant Remover (NameError)
rubygem-xmlrpc: ??? RuntimeError: HTTP-Error: 400 Bad Request
rubygem-method_source: Prism incompatibility https://github.com/banister/method_source/pull/84
```


----------------------------------------
Bug #20857: Don't change `Hash#inspect` formatting
https://bugs.ruby-lang.org/issues/20857#change-110323

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Assignee: matz (Yukihiro Matsumoto)
* ruby -v: ruby 3.4.0dev (2024-10-15 master 3da3cabf98) +PRISM [x86_64-linux]
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
Testing Ruby 3.4 in Fedora, I just hit issue like this in AsciiDoctor test suite:

~~~
  1) Failure:
Minitest::Test::TestExtensions::TestIntegration#test_should_assign_captures_correctly_for_inline_macros [test/extensions_test.rb:1382]:
--- expected
+++ actual
@@ -1,9 +1,9 @@
 "target=\"\", attributes={}
-target=\"value,key=val\", attributes={1=>\"value\", \"key\"=>\"val\", \"name\"=>\"value\"}
-target=\"\", attributes={\"text\"=>\"\"}
-target=\"[text]\", attributes={\"text\"=>\"[text]\"}
+target=\"value,key=val\", attributes={1 => \"value\", \"key\" => \"val\", \"name\" => \"value\"}
+target=\"\", attributes={\"text\" => \"\"}
+target=\"[text]\", attributes={\"text\" => \"[text]\"}
 target=\"target\", attributes={}
-target=\"target\", attributes={1=>\"value\", \"key\"=>\"val\", \"name\"=>\"value\"}
-target=\"target\", attributes={\"text\"=>\"\"}
-target=\"target\", attributes={\"text\"=>\"[text]\"}
+target=\"target\", attributes={1 => \"value\", \"key\" => \"val\", \"name\" => \"value\"}
+target=\"target\", attributes={\"text\" => \"\"}
+target=\"target\", attributes={\"text\" => \"[text]\"}
 target=\"target\", attributes={}"
~~~

This suggest that `Hash#inspect` formatting was changed and there are additional spaces around hash rocket. Is the space really worth of the troubles? BTW [here](https://github.com/asciidoctor/asciidoctor/issues/4634#issuecomment-2449497487) is AsciiDoctor upstream reaction and I share the sentiment.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/