[#118346] [Ruby master Bug#20586] Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted — "ivoanjo (Ivo Anjo) via ruby-core" <ruby-core@...>
Issue #20586 has been reported by ivoanjo (Ivo Anjo).
13 messages
2024/06/19
[ruby-core:118166] [Ruby master Bug#20416] IO#read doesn't preserve buffer encoding if `maxlen = nil`
From:
"byroot (Jean Boussier) via ruby-core" <ruby-core@...>
Date:
2024-06-04 07:16:01 UTC
List:
ruby-core #118166
Issue #20416 has been updated by byroot (Jean Boussier).
Yeah, I don't think it's a bug. @nobu should we close?
----------------------------------------
Bug #20416: IO#read doesn't preserve buffer encoding if `maxlen = nil`
https://bugs.ruby-lang.org/issues/20416#change-108607
* Author: andrykonchin (Andrew Konchin)
* Status: Open
* ruby -v: 3.3.0
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
`IO#read(nil, buffer)` doesn't change buffer's encoding, but it does when `maxlen` parameter is specified:
```ruby
buffer = "".encode(Encoding::ISO_8859_1)
p File.open("test.rb").read(1000, buffer).encoding # => #<Encoding:ISO-8859-1>
buffer = "".encode(Encoding::ISO_8859_1)
p File.open("test.rb").read(nil, buffer).encoding # => #<Encoding:UTF-8>
```
I would expect changing buffer encoding in all the cases.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/