[ruby-core:115782] [Ruby master Bug#19683] ruby-3.3.0-preview1 does not build with BSD make without --with-baseruby

Issue #19683 has been updated by jeremyevans0 (Jeremy Evans).


I traced this issue to commit:a1b01e7701f9fc370f8dff777aad6d39a2c5a3e3 (lrama), because that introduced the use of BASERUBY, which is what currently breaks this:

```diff
--- a/common.mk
+++ b/common.mk
@@ -298,7 +298,8 @@ configure-ext: $(EXTS_MK)
 
 build-ext: $(EXTS_MK)
        $(Q)$(MAKE) -f $(EXTS_MK) $(mflags) libdir="$(libdir)" LIBRUBY_EXTS=$(LIBRUBY_EXTS) \
-           EXTENCS="$(ENCOBJS)" MINIRUBY="$(MINIRUBY)" UPDATE_LIBRARIES=no $(EXTSTATIC)
+           EXTENCS="$(ENCOBJS)" BASERUBY="$(BASERUBY)" MINIRUBY="$(MINIRUBY)" \
+           UPDATE_LIBRARIES=no $(EXTSTATIC)
        $(Q)$(MAKE) $(EXTS_NOTE)
 
 exts-note: $(EXTS_MK)
@@ -1208,8 +1209,8 @@ $(srcdir)/ext/ripper/ripper.c: $(srcdir)/ext/ripper/tools/preproc.rb $(srcdir)/p
        $(Q) $(CHDIR) $(@D) && \
        $(CAT_DEPEND) depend | \
        $(exec) $(MAKE) -f - $(mflags) \
-               Q=$(Q) ECHO=$(ECHO) RM="$(RM1)" BISON="$(YACC)" top_srcdir=../.. srcdir=. VPATH=../.. \
-               RUBY="$(BASERUBY)" PATH_SEPARATOR="$(PATH_SEPARATOR)" LANG=C
+               Q=$(Q) ECHO=$(ECHO) RM="$(RM1)" top_srcdir=../.. srcdir=. VPATH=../.. \
+               RUBY="$(BASERUBY)" BASERUBY="$(BASERUBY)" PATH_SEPARATOR="$(PATH_SEPARATOR)" LANG=C

```

This isn't necessarily specific to BASERUBY, though. The underlying issue is that `exts.mk` (created from `templates/exts.mk.tmpl`) uses `$(MFLAGS)`:

```
ruby:
	$(Q)$(MAKE) $(MFLAGS) $(SUBMAKEOPTS) $@
```

This doesn't work as the `;` inside BASERUBY (defined as `echo executable host ruby is required.  use --with-baseruby option.; false`) is not quoted.  I'm not sure how to get it quoted correctly (neither the `Q` or `QL` modifiers work), I'm checking with the OpenBSD make maintainer.

One possible way to workaround the issue would be to ship a `tool/missing-baseruby` file that contained:

```
#!/bin/sh
echo "executable host ruby is required.  use --with-baseruby option."
exit 1
```

And use that as `BASERUBY`.

However, I think the best fix would be to not use `BASERUBY` here.  This is after `miniruby` and `ruby` are built, we should be able to use the built ruby instead of `BASERUBY` when building extensions, unless I'm missing something.

----------------------------------------
Bug #19683: ruby-3.3.0-preview1 does not build with BSD make without --with-baseruby
https://bugs.ruby-lang.org/issues/19683#change-105718

* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Target version: 3.3
* ruby -v: ruby 3.3.0preview1 (2023-05-12 master a1b01e7701) [x86_64-openbsd7.3]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
ruby-3.3.0-preview1 does not build with BSD make without `--with-baseruby`. However, it builds fine with GNU make and when using BSD make with `--with-baseruby`.  Previous Ruby tarball releases have built fine with BSD make without `--with-baseruby`, so this issue has been introduced recently.

When building with BSD make without `--with-baseruby`, building fails after generating RI format with:

```
/bin/sh:  false: not found
*** Error 127 in . (exts.mk:94 'ruby': @make   UPDATE_LIBRARIES=no EXTENCS=dmyenc.o BASERUBY=echo\ executable\ host\ ruby\ is\ required.\ \ ...)
*** Error 2 in /home/jeremy/local/ruby-3.3.0-preview1 (Makefile:948 'build-ext': @make -f exts.mk    libdir="/usr/local/lib" LIBRUBY_EXTS=./...)

```



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/