From: "Eregon (Benoit Daloze) via ruby-core" <ruby-core@...>
Date: 2022-12-29T22:41:34+00:00
Subject: [ruby-core:111517] [Ruby master Bug#19279] Allow `Coverage.supported?` to recognize oneshot lines mode

Issue #19279 has been updated by Eregon (Benoit Daloze).





@mame https://bugs.ruby-lang.org/issues/19026#note-7 should be a good enough reason on its own IMHO.

And as we have seen with recent simplecov issues, it's always a bad idea to use a version check for checking if a feature is available.



----------------------------------------

Bug #19279: Allow `Coverage.supported?` to recognize oneshot lines mode

https://bugs.ruby-lang.org/issues/19279#change-100885



* Author: kevin-j-m (Kevin Murphy)

* Status: Closed

* Priority: Normal

* ruby -v: ruby 3.2.0 (2022-12-25 revision a528908271) [x86_64-darwin22]

* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN

----------------------------------------

Currently in Ruby 3.2.0, Coverage's new `supported?` method (introduced in https://bugs.ruby-lang.org/issues/19026) does not recognize support for oneshot lines. Given that it is an available mode of coverage, I'm proposing that `Coverage.supported?` report that oneshot lines is supported.



Current behavior:

``` bash

~|��� ruby -v

ruby 3.2.0 (2022-12-25 revision a528908271) [x86_64-darwin22]

~|��� irb

irb(main):001:0> require "coverage"

=> true

irb(main):002:0> Coverage.supported?(:lines)

=> true

irb(main):003:0> Coverage.supported?(:oneshot_lines)

=> false

```









-- 

https://bugs.ruby-lang.org/

 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/