From: Farrel Lifson <farrel.lifson@...>
Date: 2007-03-15T16:05:09+09:00
Subject: Re: [ ruby-Patches-9055 ] Dynamic Array#join with block

On 11/03/07, Sam Roberts <sroberts@uniserve.com> wrote:
> Quoting farrel.lifson@gmail.com, on Sun, Mar 11, 2007 at 08:51:12AM +0900:
> > On 09/03/07, Nobuyoshi Nakada <nobu@ruby-lang.org> wrote:
> > >+VALUE
> > >+rb_ary_join_block(VALUE ary,VALUE sep)
> > >+{
> > >+  if (RARRAY_LEN(ary) == 0) return rb_str_new(0,0);
> > >+  int taint = Qfalse;
> > >
> > >This results syntax error on non-C99 platforms.
> >
> > Hmm.. not good especially as I basically copied and modified it
> > straight from rb_ary_join. I will change it so that it is exactly like
> > rb_ary_join (which I assume compiles fine on non-C99).
>
> Definitions must be before statements in C, until C99. Perhaps you
> inserted the conditional before the "int taint"?
>
> > >And, sorry but the indentation looks quite odd to me.  Setting tab width
> > >to 2?
> > That was some bad indenting on my part. My vim set up is to expand
> > tabs to two spaces. Is there an 'official' style for the Ruby?
>
>  vim:ts=8:sw=2:noet:
>
> Cheers,
> Sam


Thanks! I've made the changes and added an updated patch to the tracker.

Farrel