[ruby-core:101935] [Ruby master Feature#17316] On memoization

Issue #17316 has been updated by marcandre (Marc-Andre Lafortune).


Dan0042 (Daniel DeLorme) wrote in #note-8:
> marcandre (Marc-Andre Lafortune) wrote in #note-3:
> > Gem is here: https://github.com/marcandre/ractor-cache
> > Comments welcome :-)
> 
> Since you say so... :-)
> An additional strategy might to wrap the @cache in a Ractor::LVar (if/once available).

Indeed. I refactored it to use `Ractor.current[]` and a `WeakMap`. I removed the other ways as I can't think of a case where this isn't the best way to go.


----------------------------------------
Feature #17316: On memoization
https://bugs.ruby-lang.org/issues/17316#change-89783

* Author: sawa (Tsuyoshi Sawada)
* Status: Open
* Priority: Normal
----------------------------------------
I have seen so many attempts to memoize a value in the form:

```ruby
@foo ||= some_heavy_calculation(...)
```

improperly, i.e., even when the value can potentially be falsy. This practice is wide spread, and since in most cases memoization is about efficiency and it would not be critical if it does not work correctly, people do not seem to care so much about correcting the wrong usage.

In such case, the correct form would be:

```ruby
unless instance_variable_defined?(:@foo)
  @foo = some_heavy_calculation(...)
end
```

but this looks too long, and perhaps that is keeping people away from using it.

What about allowing `Kernel#instance_variable_set` to take a block instead of the second argument, in which case the assignment should be done only when the instance variable is not defined?

```ruby
instance_variable_set(:@foo){some_heavy_calculation(...)}
```

Or, if that does not look right or seems to depart from the original usage of `instance_variable_set`, then what about having a new method?

```ruby
memoize(:foo){some_heavy_calculation(...)}
```



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>