[#99868] [Ruby master Bug#17144] Tempfile.open { ... } does not unlink the file — eregontp@...
Issue #17144 has been reported by Eregon (Benoit Daloze).
15 messages
2020/09/03
[ruby-core:100120] [Ruby master Feature#17143] Improve support for warning categories
From:
shyouhei@...
Date:
2020-09-25 05:04:03 UTC
List:
ruby-core #100120
Issue #17143 has been updated by shyouhei (Shyouhei Urabe).
- I'm not against adding the category keyword. However,
- I guess it is quite hard for us to +1 the "Add categories for all core warnings" commit at once.
- It might contain OK changes, but might also contain questionable ones.
- Do you really need to do this in a big changeset like this? Can you split it into each categories, and let us consider case-by-case?
----------------------------------------
Feature #17143: Improve support for warning categories
https://bugs.ruby-lang.org/issues/17143#change-87688
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
----------------------------------------
Support was recently added for Warning.warn to accept a `category` keyword. However, the initial implementation was limited to having `rb_warn_deprecated` and `rb_warn_deprecated_to_remove` use the `:deprecated` value for the `category` keyword.
It doesn't make sense to me to have a `category` keyword if it is only used for deprecation, so I propose we extend the support so that `Kernel#warn` accepts a category keyword (for Ruby-level warnings) and `rb_category_warn` and `rb_category_warning` functions be added to the C-API (for C-level warnings). I also propose that we change existing `rb_warn` and `rb_warning` calls to `rb_category_warn` and `rb_category_warning`, so that all warnings issued by core Ruby are issued with an appropriate category.
I have implemented support for this in a pull request: https://github.com/ruby/ruby/pull/3508
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>